[vlc-devel] commit: vlc_object_get() sucks badly enough, no need to add more bugs ( Rémi Denis-Courmont )

git version control git at videolan.org
Wed May 28 19:32:49 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rem at videolan.org> | Wed May 28 20:34:26 2008 +0300| [2e7d3d7d1581487800fbdb820e26559b5f43de15]

vlc_object_get() sucks badly enough, no need to add more bugs

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2e7d3d7d1581487800fbdb820e26559b5f43de15
---

 src/misc/objects.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/misc/objects.c b/src/misc/objects.c
index 91569a4..4a16e1b 100644
--- a/src/misc/objects.c
+++ b/src/misc/objects.c
@@ -648,10 +648,12 @@ void * vlc_object_get( int i_id )
         if( obj->i_object_id == i_id )
         {
             vlc_object_yield( obj );
-            return obj;
+            goto out;
         }
     }
+    obj = NULL;
 
+out:
     vlc_mutex_unlock( &structure_lock );
     return obj;
 }




More information about the vlc-devel mailing list