[vlc-devel] commit: When checking for filters overflow, actually handle the error ( CID 48) ( Rémi Denis-Courmont )

git version control git at videolan.org
Fri May 30 18:24:17 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rem at videolan.org> | Fri May 30 19:25:22 2008 +0300| [375c32ffcacd8781b7c5329d4d7714d8c879625b]

When checking for filters overflow, actually handle the error (CID 48)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=375c32ffcacd8781b7c5329d4d7714d8c879625b
---

 src/video_output/vout_subpictures.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/video_output/vout_subpictures.c b/src/video_output/vout_subpictures.c
index b76de98..a22e205 100644
--- a/src/video_output/vout_subpictures.c
+++ b/src/video_output/vout_subpictures.c
@@ -148,6 +148,8 @@ int spu_ParseChain( spu_t *p_spu )
         p_spu->pp_filter[p_spu->i_filter]->p_module =
             module_Need( p_spu->pp_filter[p_spu->i_filter],
                          "sub filter", psz_name, true );
+        free( psz_name );
+
         if( p_spu->pp_filter[p_spu->i_filter]->p_module )
         {
             filter_owner_sys_t *p_sys = malloc( sizeof(filter_owner_sys_t) );
@@ -170,9 +172,9 @@ int spu_ParseChain( spu_t *p_spu )
         if( p_spu->i_filter >= 10 )
         {
             msg_Dbg( p_spu, "can't add anymore filters" );
+            break;
         }
 
-        free( psz_name );
     }
     free( val.psz_string );
 




More information about the vlc-devel mailing list