[vlc-devel] commit: macosx: Sanitization. Suppress non-sense yield(->p_input) release(- >p_input), invalidate the manage thread, make sure we don' t re-run a timer when the interface is dead. (Shoot 'em up!) (Pierre d' Herbemont )

[Pierre d'Herbemont]

On May 31, 2008, at 4:33 PM, Rémi Denis-Courmont wrote:

> Le Saturday 31 May 2008 14:36:21 git version control, vous avez  
> écrit :
>> Remember, you can't assume that in your thread an object is alive  
>> if you
>> don't delimit want-to-be safe place by a lock(p_obj)/unlock(p_obj).  
>> Also,
>> yield(p_playlist->p_input) is invalid if you don't lock the playlist
>> before.
>
>> The correct way here is to use vlc_object_find() as the locking
>> policy of the playlist is not safe.
>
> That's a good point. OTOH, I wonder how this interacts with input- 
> slave.

> Perhaps we should have a dedicated thread-safe function for this?

+1.

Pierre.