[vlc-devel] [PATCH] better libvlc audio handling

Rémi Denis-Courmont rem at videolan.org
Sat Nov 1 14:37:32 CET 2008


Le samedi 1 novembre 2008 15:21:48 Lukas Durfina, vous avez écrit :
> On Sat, Nov 1, 2008 at 2:13 PM, Rémi Denis-Courmont <rem at videolan.org> 
wrote:
> > Seems to introduce a bunch of enums as return or parameter type.
> > I have no problem with that. But I hope you understand that it means it
> > can never ever be extended. As far as I know, the compiler can assume
> > that an enum variable never has a trap value.
>
> Maybe they wouldnt need to extended, but I can add something like
> libvlc_AudioOutputDevice_ReservedValue   4 times at the end
> of both enums, would it help a bit?

That's rather silly. If it might end up being extended, better use int for the 
parameters and return types. You can still use the enum for the value names.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary



More information about the vlc-devel mailing list