[vlc-devel] [PATCH] better libvlc audio handling

Lukas Durfina lukas.durfina at gmail.com
Mon Nov 3 22:23:58 CET 2008

On Mon, 03 Nov 2008 19:49:16 +0100, Rémi Duraffort <ivoire at via.ecp.fr>  

> Hi,
> just a little remark.
> In this function:
> VLC_PUBLIC_API void libvlc_audio_output_device_set(libvlc_instance_t

> Why not checking  that psz_device_id != NULL at the begining, so if it's
> NULL you don't do any malloc+free.
> Seams good to me.
> And thanks for redoing patch for every remarks !!


  good point... and thanks for remarks, without them it wouldnt be
pretty code.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-libvlc-better-audio-handling.patch
Type: application/octet-stream
Size: 21373 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20081103/e8b7a389/attachment.obj>

More information about the vlc-devel mailing list