[vlc-devel] [PATCH 1/1] codec/dirac: Rewrite libdirac(-research) encoding support

[David Flynn]

On 2008-11-11, Laurent Aimar <fenrir at via.ecp.fr> wrote:
> On Mon, Nov 10, 2008, David Flynn wrote:
>  The workaround I see, is to use 
>  - a string list with something like "auto", "on", "off"
>  - an integer list with -1, 0, 1 and comments.
>  - an integer as you do but with a range including -1
>  - a new variable type (a lot of work)

It looked much simpler to make vlc cope when i was still allowed to use
var_Get() -- would've been possible to add a member to that structure to
say if it were undefined or not.

For the moment, you've got two choices:
 - Either accept this as is and we can work on a way to properly fix it
 - Or i remove the options, cripple the things the user can twiddle
   while something to fix this is invented.

>> >> +            /* extract data from encoder temporary buffer. */
>> >  There, if p_sys->p_dirac->enc_buf.size >= p_sys->p_dirac I think you can
>> > warn about (probable) output buffer overflow.
>  Well bad copy past+mix up, sorry. I meant :
>  p_sys->p_dirac->enc_buf.size >= p_sys->i_buffer_out
> (not sure, as the dirac library may stop writing before the last
> byte).
>  If not that easy, not blocking.

Without an indepth look, i still don't think it works that way.