[vlc-devel] [PATCH 1/1] codec/dirac: Rewrite libdirac(-research) encoding support

[David Flynn]

On 2008-11-11, Laurent Aimar <fenrir at via.ecp.fr> wrote:
> On Tue, Nov 11, 2008, David Flynn wrote:
>> On 2008-11-11, Laurent Aimar <fenrir at via.ecp.fr> wrote:
>> > On Mon, Nov 10, 2008, David Flynn wrote:
>> >> On 2008-11-10, davidf+nntp at woaf.net <davidf+nntp at woaf.net> wrote:
>> >> >  static block_t *Encode( encoder_t *p_enc, picture_t *p_pic )
>> >> How does one know when the input has ended? (in order to flush the
>> >> encoder and tidy up any housekeeping?
>> >  Actually, there is no way to know it.
>> 
>> thats really unfortunate, since it is good practice for us to signal an
>> EOS marker.
>> 
>> But worse, surely this means that i'll also not be able to extract the
>> last few (or whatever) out of the encoder
>  Yes :(
>  
>  A clean solution is welcome. Your idea of pushing NULL picture until the
> encoder does not output data anymore is fine.
>  You will need to update transcode.c for that (and maybe fix a few encoder
> to at least issue a warning and not segfault).

Ok, some food for thought.  It'd be quite easy to fix the encoders with
a nullity check.

..david