[vlc-devel] [PATCH 3 of 4] dshow: add HDYC mediasubtype

[David Flynn]

> On Wed, Oct 15, 2008 at 12:04:29AM +0200, Edouard Gomez wrote :
>> dshow: add HDYC mediasubtype
>
>
>> 
>> diff --git a/modules/access/dshow/filter.cpp b/modules/access/dshow/filter.cpp
>> --- a/modules/access/dshow/filter.cpp
>> +++ b/modules/access/dshow/filter.cpp
>> @@ -120,6 +120,7 @@
>>  const GUID MEDIASUBTYPE_YUY2 = {0x32595559, 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}};
>>  const GUID MEDIASUBTYPE_YVYU = {0x55595659, 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}};
>>  const GUID MEDIASUBTYPE_UYVY = {0x59565955, 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}};
>> +const GUID MEDIASUBTYPE_HDYC = {0x43594448, 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}};
>>  
>>  /* Planar YUV formats */
>>  const GUID MEDIASUBTYPE_YVU9 = {0x39555659, 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}};
>> @@ -276,6 +277,8 @@
>>                 i_fourcc = VLC_FOURCC( 'Y', 'U', 'Y', '2' );
>>              else if( media_type.subtype == MEDIASUBTYPE_UYVY )
>>                 i_fourcc = VLC_FOURCC( 'U', 'Y', 'V', 'Y' );

On 2008-10-15, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> I will apply when Patch2 of set is applied.
Patch 2 can be ignored if this:

>> +            else if( media_type.subtype == MEDIASUBTYPE_HDYC )
>> +	       i_fourcc = VLC_FOURCC( 'H', 'D', 'Y', 'C');

(NB, spurious tab in the above line)

is changed to:

+            else if( media_type.subtype == MEDIASUBTYPE_HDYC )
+            i_fourcc = VLC_FOURCC( 'U', 'Y', 'V', 'Y');

and add a comment saying:
/* HDYC uses UYVY sample positions but Rec709 colourimetry */
/* FIXME: When VLC understands colourspace, something will need
 * to be added / changed here */

I suggest this on the basis that VLC doesn't have any concept of
colourspace at the moment.

..david