[vlc-devel] [PATCH] Playlists, Dbus

Rémi Denis-Courmont rem at videolan.org
Fri Nov 21 01:17:33 CET 2008

On Friday 21 November 2008 01:41:18 Polar Humenn, you wrote:
> This patch solves a problem I ran into with --enable-debug, playlists,
> locking and the DBUS control module. Variable callbacks where getting
> called that the Dbus controlling module placed on playlists, causing
> deadlock. After a little research, I found that the playlists were
> incorrectly locked during possible callbacks, and those callbacks were
> operating on playlists within the Dbus module.
> This patch solves both.

Please avoid coallescing patches unless there is a specific reason to do so, 
and please use git-format-patch.

Specifically, you could use playlist_CurrentInputLocked() inside 
playlist_CurrentInput() instead of duplicating code. I also don't understand 
the deal with b_playlist_locked in the updated DBus code, but maybe I'm 
stupid or I should read the source code context.

> There is also a minor typo fixed in threads.c.
> I also have other issues with variable callbacks (which affects other
> work I'm doing) to which I will submit another patch, but is not
> needed for this work to proceed.
> Enjoy,
> Cheers,
> -Polar

Rémi Denis-Courmont

More information about the vlc-devel mailing list