[vlc-devel] [PATCH] Playlist locking

Laurent Aimar fenrir at via.ecp.fr
Mon Nov 24 19:16:06 CET 2008

On Fri, Nov 21, 2008, Polar Humenn wrote:
> This attached patch fixes playlist locking such that playlist is
> guarranteed to be unlocked when variable callbacks are called.

 I would really prefer the otherway around. That is locking before calling
a callback.
 When it is not locked, locking isn't a problem (except maybe with some
module that will need fixes). But unlocking can lead to incoherent state.
 For example, I know that due to the way some events are forwarded to the
playlist, if you unlock in the wrong thread, you end up with missed events
(like eof on a input).
 Now I do not know the playlist code well enough to be sure it is the right
thing, can someone comment too ?


More information about the vlc-devel mailing list