[vlc-devel] RE : [PATCH] - vmem (more libvlc-friendly)

[brezhoneg1]

See answer inside email

-----Message d'origine-----
De : vlc-devel-bounces at videolan.org
[mailto:vlc-devel-bounces at videolan.org] De la part de Pierre d'Herbemont
Envoyé : vendredi 28 novembre 2008 18:54
À : Mailing list for VLC media player developers
Objet : Re: [vlc-devel] [PATCH] - vmem (more libvlc-friendly)

Hello,

I fear this is too risky. Basically it means giving the ability to  
write random content at the specified memory location, just using an  
MRL.

One thing that would be great is to set some nice public libvlc  
function to specifically use the vmem video output. For instance:

libvlc_media_player_set_vmem(mp, width, height, ...)


Answer:

Yes, a well documented function may be nicer.

I guess the vmem implementation will still need this patch to allow
multiple inputs (media_player in libvlc) to benefit from it. (whether
directly or via a function to wrap it)

Also, for the time being, this patch could solve another problem :
Developers may figure out that creating multiple instances of libvlc
(libvlc_new ...) will allow multiple instances of vmem. Yet, instances
of libvlc share the same module/config repository. Creating a new
instance of libvlc overwrites options from a previous one. (Btw,
shouldn't it be regarded as a bug ?). So the developer's experience
isn't so great. At least, this patch could help make him/her successful
without risk being greater than it is today (same syntax, same issues,
just made available at the media level in addition to the libvlc level).


Erwan10
------------------------------------------------------------------


Pierre.

On Nov 28, 2008, at 6:19 PM, brezhoneg1 wrote:

> Please, find a proposal for a slight change in vmem
> (modules/video_output/vmem.c)
>
> With this patch, vmem gets its parameters through the inheritance
> mechanism usually used within vlc, instead of just getting them from  
> the
> initial config. This allows multiple inputs to benefit from vmem  
> (libvlc
> api).
>
> Also, the example provided at
> http://wiki.videolan.org/LibVLC_SampleCode_SDL was no longer  
> working. (a
> lock interface changed between vlc 0.9.x and vlc1.x.x). Attached to  
> this
> email is an updated example. In addition to the change made for
> vlc1.x.x, it shows multiple inputs.
>
> Both the patch and the example have been tested.
>
> Erwan10
>
>
> < 
> patch_source_vmem 
> .diff><test_sdl.c>_______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
http://mailman.videolan.org/listinfo/vlc-devel