[vlc-devel] [PATCH 4/7] demux/ogg: Follow coding style for ogg dirac functions

[Laurent Aimar]

Hi,
On Thu, Nov 27, 2008, davidf+nntp at woaf.net wrote:
> -    static const struct {
> -        uint32_t u_n /* numerator */, u_d /* denominator */;
> +    const struct {
> +        uint32_t u_n /* numerator */;
> +        uint32_t u_d /* denominator */;
>      } p_dirac_frate_tbl[] = { /* table 10.3 */
>          {1,1}, /* this first value is never used */
>          {24000,1001}, {24,1}, {25,1}, {30000,1001}, {30,1},
> @@ -1823,7 +1824,7 @@ static void Ogg_ReadDiracHeader( logical_stream_t *p_stream,
>      };
>      static const size_t u_dirac_frate_tbl = sizeof(p_dirac_frate_tbl)/sizeof(*p_dirac_frate_tbl);
>  
> -    static const uint32_t pu_dirac_vidfmt_frate[] = { /* table C.1 */
> +    const uint32_t pu_dirac_vidfmt_frate[] = { /* table C.1 */
>          1, 9, 10, 9, 10, 9, 10, 4, 3, 7, 6, 4, 3, 7, 6, 2, 2, 7, 6, 7, 6,
>      };
 Keeping the static key word is better. So I will not apply this one.

-- 
fenrir