[vlc-devel] commit: Hotkeys: remove unuseful test on p_playlist: If p_playlist is NULL here, you are dead just before. ( Jean-Baptiste Kempf )

git version control git at videolan.org
Wed Oct 1 20:54:50 CEST 2008


vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Wed Oct  1 11:51:33 2008 -0700| [58208c694d1eb2d4a0d8c810d92873318748d2f3] | committer: Jean-Baptiste Kempf 

Hotkeys: remove unuseful test on p_playlist: If p_playlist is NULL here, you are dead just before.

Can pl_Hold return NULL ?

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=58208c694d1eb2d4a0d8c810d92873318748d2f3
---

 modules/control/hotkeys.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/modules/control/hotkeys.c b/modules/control/hotkeys.c
index 9766301..81d3868 100644
--- a/modules/control/hotkeys.c
+++ b/modules/control/hotkeys.c
@@ -193,8 +193,7 @@ static void Run( intf_thread_t *p_intf )
         /* Quit */
         if( i_action == ACTIONID_QUIT )
         {
-            if( p_playlist )
-                playlist_Stop( p_playlist );
+            playlist_Stop( p_playlist );
             vlc_object_kill( p_intf->p_libvlc );
             vlc_object_kill( p_intf );
             ClearChannels( p_intf, p_vout );




More information about the vlc-devel mailing list