[vlc-devel] commit: Avoid a malloc(0) ( Rémi Duraffort )

git version control git at videolan.org
Thu Oct 2 21:13:27 CEST 2008


vlc | branch: 0.9-bugfix | Rémi Duraffort <ivoire at videolan.org> | Wed Sep 17 22:00:52 2008 +0200| [d2c3e2771eeecb4e366ab50d919c6f18d626107a] | committer: Derk-Jan Hartman 

Avoid a malloc(0)
(cherry picked from commit 4fa0611dd2ce05655d8e3be69452290e7b28cf51)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d2c3e2771eeecb4e366ab50d919c6f18d626107a
---

 modules/demux/mp4/mp4.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/modules/demux/mp4/mp4.c b/modules/demux/mp4/mp4.c
index ebe914d..5ad7349 100644
--- a/modules/demux/mp4/mp4.c
+++ b/modules/demux/mp4/mp4.c
@@ -1688,9 +1688,12 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track,
                 if( p_avcC )
                 {
                     p_track->fmt.i_extra = p_avcC->data.p_avcC->i_avcC;
-                    p_track->fmt.p_extra = malloc( p_avcC->data.p_avcC->i_avcC );
-                    memcpy( p_track->fmt.p_extra, p_avcC->data.p_avcC->p_avcC,
-                            p_track->fmt.i_extra );
+                    if( p_track->fmt.i_extra > 0 )
+                    {
+                        p_track->fmt.p_extra = malloc( p_avcC->data.p_avcC->i_avcC );
+                        memcpy( p_track->fmt.p_extra, p_avcC->data.p_avcC->p_avcC,
+                                p_track->fmt.i_extra );
+                    }
                 }
                 else
                 {




More information about the vlc-devel mailing list