[vlc-devel] Gsoc 2008 timeshift patch 1

[Rémi Denis-Courmont]

Le dimanche 28 septembre 2008 12:13:03 Dylan Yudaken, vous avez écrit :
> Rémi Denis-Courmont wrote:
> > Le jeudi 25 septembre 2008 19:01:18 Dylan Yudaken, vous avez écrit :
> >> attached with fixes.
> >
> > Do not replace _correct_ unsigned (or size_t, or even ssize_t for that
> > matter) with dubious int.
>
> changed, sorry I missed that
>
> > I also don't get the point of the delete-on-quit option... Why would
> > someone want to not delete the files?
>
> It is quite useful if, for instance, you are watching TV with vlc and
> want to dump all the data files somewhere after using vlc (to watch
> again).

Hmm, should you not be using dump/demuxdump/record for this?

> it deletes them anyway on startup again. 

*IMHO*, this makes keeping the file quite useless in the first place. It is 
unfortunate that nobody else has been reviewing this :( so there is no third 
opinion.

But most importantly, what happens if you have multiples concurrent VLC 
instances??? With normal temporary files, they will use separate buffers.

> > Finally, the C run-time normally takes care of deleting temporary files,
> > which is more reliable (if VLC crashes) and safer (not deleting someone
> > else file) than doing it by hand.
>
> agreed - but then you cant keep files after using vlc.

Right.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary