[vlc-devel] commit: Redefine vlc_dictionary_clear() and vlc_dictionary_remove_value_for_key() Allow passing a pointer to a function and an opaque pointer in order to free the memory if the values of the dictionary contain allocated memory . (Adrien Maglo )

[Rémi Denis-Courmont]

On Sun, 5 Oct 2008 22:48:15 +0200, Pierre d'Herbemont <pdherbemont at free.fr>
wrote:
> On Oct 5, 2008, at 9:53 PM, git version control wrote:
> 
>> vlc | branch: master | Adrien Maglo <magsoft at videolan.org> | Tue Sep  
>> 30 09:10:25 2008 +0200| [639eb0c5ab082e14c1fc9c32967b6d338032c2c9] |  
>> committer: Rémi Duraffort
>>
>> Redefine vlc_dictionary_clear() and  
>> vlc_dictionary_remove_value_for_key() Allow passing a pointer to a  
>> function and an opaque pointer in order to free the memory if the  
>> values of the dictionary contain allocated memory.
> 
> IMHO, function pointer should be set in _init(), not in remove... This  
> is less error prone at least, and then less intrusive.

*Ahem* IMHO this while hash table API should be rethought.

-- 
Rémi Denis-Courmont