[vlc-devel] commit: Fix missing declaration (supposedly crash on amd64) ( Rémi Denis-Courmont )

[Felix Paul Kühne]

Am 06.10.2008 um 20:17 schrieb Rémi Denis-Courmont:

> Le lundi 6 octobre 2008 21:12:43 Derk-Jan Hartman, vous avez écrit :
>> http://kerneltrap.org/Git/1.5.6_Relatively_Small_Impact_Changes
>> * git cherry-pick' and 'git revert' can add a sign-off
>>
>> Ergo, this is a rather new feature (June 2008) of git.
>
> And how is that an excuse for backporting stuff without putting your  
> name, and
> without checking that it makes sense?

I learnt about this option quite recently, too. It isn't too obvious  
if you are using git for a short time and especially for this specific  
project only.

Anyway, the commit log clearly states that Derk-Jan backported your  
commit:

>
> vlc | branch: 0.9-bugfix | Rémi Denis-Courmont <rdenis at simphalempin.com 
> > | Sun Oct  5 16:11:00 2008 +0300|  
> [1d80eeb8927089589870ae58bf7b2f089691e430] | committer: Derk-Jan  
> Hartman
>

so it is pretty much obvious that you are the original author, while  
he's the committer of this patch to the bugfix-branch. Whether this  
commit actually makes sense is a completely different question.


Anyway, we had this discussion before. Does it really need to be  
repeated, especially with this inflexion?



Felix