[vlc-devel] commit: ts: double free (CID 245) (Derk-Jan Hartman )

git version control git at videolan.org
Thu Oct 9 18:34:31 CEST 2008


vlc | branch: master | Derk-Jan Hartman <hartman at videolan.org> | Thu Oct  9 18:00:29 2008 +0200| [264444a1699298ecdf4be399563ef5eb478007e0] | committer: Derk-Jan Hartman 

ts: double free (CID 245)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=264444a1699298ecdf4be399563ef5eb478007e0
---

 modules/demux/ts.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/modules/demux/ts.c b/modules/demux/ts.c
index 3549913..c0c12e5 100644
--- a/modules/demux/ts.c
+++ b/modules/demux/ts.c
@@ -857,7 +857,6 @@ static void Close( vlc_object_t *p_this )
     if( p_sys->b_udp_out )
     {
         net_Close( p_sys->fd );
-        free( p_sys->buffer );
     }
     vlc_mutex_lock( &p_sys->csa_lock );
     if( p_sys->csa )
@@ -889,10 +888,9 @@ static void Close( vlc_object_t *p_this )
             fclose( p_sys->p_file );
             p_sys->p_file = NULL;
         }
-
-        free( p_sys->buffer );
     }
 
+    free( p_sys->buffer );
     free( p_sys->psz_file );
     p_sys->psz_file = NULL;
 




More information about the vlc-devel mailing list