[vlc-devel] commit: mmap: Correct [cbc1122ac4551505181ea048ca14a5f87041090f] ( Derk-Jan Hartman )

[Rémi Denis-Courmont]

Le vendredi 10 octobre 2008 16:00:27 Laurent Aimar, vous avez écrit :
> On Fri, Oct 10, 2008, git version control wrote:
> > vlc | branch: master | Derk-Jan Hartman <hartman at videolan.org> | Fri Oct
> > 10 14:55:49 2008 +0200| [34aef4ada6758f39d5af2300b1ac74acdc0b567c] |
> > committer: Derk-Jan Hartman
> >
> > mmap: Correct [cbc1122ac4551505181ea048ca14a5f87041090f]
>
>  Here, VLC segfaults when the file being read is truncated.

Not that it would be any better, but it should catch SIGBUS, not SIGSEGV.

>  So I would propose to change the mmap priority to 0 until/unless a clean
>  fix can be found.

I would rather put --file-mmap to false on all platforms by default. Although 
it's a bit slower, it won't need recompile to enable it.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary