[vlc-devel] [PATCH 2 of 6] avcodec: add HDYC to known ffmpeg chroma table

Rémi Denis-Courmont rem at videolan.org
Sat Oct 11 09:51:47 CEST 2008


Le vendredi 10 octobre 2008 23:51:09 Derk-Jan Hartman, vous avez écrit :
> On 10 okt 2008, at 22:36, Jean-Baptiste Kempf wrote:
> > On Fri, Oct 10, 2008 at 10:24:19PM +0200, Edouard Gomez wrote :
> >> # HG changeset patch
> >> # User Edouard Gomez <ed.gomez at free.fr>
> >> # Date 1223648709 -7200
> >> # Node ID 7d010b899293774e3fd0ba63a5a29038cbacd0c6
> >> # Parent  ecd69aeb057e1909f51ce1d71773152f5b681e0c
> >> avcodec:  add HDYC to known ffmpeg chroma table
> >
> > Seems OK, thedj?
>
> As long as it is at the bottom of the list (so it's not used when
> going from ffmpeg id -> fourcc) this should be fine.

Ok guys - I know jack about video chromas, but your comments make it sound 
like this is sort of a hack. I trust you if you say it's fine. But then, I 
believe we need a clear comment in the source code at the very least.



-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary



More information about the vlc-devel mailing list