[vlc-devel] [PATCH 1 of 6] dshow: prevent division by zero

[Kaarlo Räihä]

Jean-Baptiste Kempf kirjoitti 10.10.2008 kello 23:38:
> On Fri, Oct 10, 2008 at 10:24:18PM +0200, Edouard Gomez wrote :
> > # HG changeset patch
> > # User Edouard Gomez <ed.gomez at free.fr>
> > # Date 1223648709 -7200
> > # Node ID ecd69aeb057e1909f51ce1d71773152f5b681e0c
> > # Parent  b27ef6b3315e592c09bb7cccf4320aa3158ced2d
> > dshow: prevent division by zero
> > 
> > In the DShow capture module, division by zero is possible in
> > multiple modulo statements when dealing with granularity values
> > returned by capture filters.
> > 
> > Change the code so that:
> >  - if granularity is zero, then width/height/samplingrate must be
> >    a perfect match with requested settings.
> >  - if granularity is non zero, then use the old condition tests.
> > 
> > This fixes real crashes reported by VLC users on different forums.
> > 
> > See:
> > http://forum.doom9.org/archive/index.php/t-134655.html
> >
> http://forum.videolan.org/viewtopic.php?f=2&t=37056&p=114065&hilit=blackmagi
> c
> > 
> > Tested with both a Decklink HD Extreme card and a Decklink HD Pro card.
> 
> I cannot test, but I trust you on that one...
> Seems ok for me. atmo, VLC_help ?

I don't have any DirectShow devices for testing.



...................................................................
Luukku Plus paketilla pääset eroon tila- ja turvallisuusongelmista.
Hanki Luukku Plus ja helpotat elämääsi. http://www.mtv3.fi/luukku