[vlc-devel] commit: Embedded video still crashes, so disable it - refs #2136. ( Rémi Denis-Courmont )

git version control git at videolan.org
Mon Oct 20 21:24:32 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Mon Oct 20 22:23:51 2008 +0300| [80c3cdfcd37a21a76db280f1683a76dc26d3ef81] | committer: Rémi Denis-Courmont 

Embedded video still crashes, so disable it - refs #2136.

This is a VLC bug, not Qt4 version dependent.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=80c3cdfcd37a21a76db280f1683a76dc26d3ef81
---

 modules/gui/qt4/qt4.cpp |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/modules/gui/qt4/qt4.cpp b/modules/gui/qt4/qt4.cpp
index ea6adf8..193a3ba 100755
--- a/modules/gui/qt4/qt4.cpp
+++ b/modules/gui/qt4/qt4.cpp
@@ -225,7 +225,7 @@ vlc_module_begin();
 
         set_callbacks( OpenDialogs, Close );
 
-#if !defined (Q_WS_X11) || HAS_QT43
+#if !defined (Q_WS_X11) /*|| HAS_QT43*/
     add_submodule();
         set_capability( "vout window", 50 );
         set_callbacks( WindowOpen, WindowClose );
@@ -455,8 +455,9 @@ static void *Thread( void *obj )
         /* Destroy first the main interface because it is connected to some
            slots in the MainInputManager */
         /* Destroy under the iface lock to sync vout QPointer */
-        delete p_mi;
     }
+    msleep( CLOCK_FREQ );
+        delete p_mi;
 
     /* Destroy all remaining windows,
        because some are connected to some slots
@@ -518,7 +519,9 @@ static int WindowOpen (vlc_object_t *obj)
     vout_window_t *wnd = (vout_window_t *)obj;
     QPointer<MainInterface> *miP;
 
+#if 1
     if (config_GetInt (obj, "embedded-video") <= 0)
+#endif
         return VLC_EGENERIC;
 
     intf_thread_t *intf = (intf_thread_t *)




More information about the vlc-devel mailing list