[vlc-devel] commit: Do not check for decoder error in the demux thread ( Rémi Denis-Courmont )

git version control git at videolan.org
Wed Oct 22 21:50:54 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Wed Oct 22 22:49:11 2008 +0300| [8209230f34c53150918d8147f02385cdd8ccc4e3] | committer: Rémi Denis-Courmont 

Do not check for decoder error in the demux thread

That was only an optimization, and it fails thread-safety.
In any case, a failed decoder will still dequeue (and discard) blocks.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=8209230f34c53150918d8147f02385cdd8ccc4e3
---

 src/input/decoder.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/input/decoder.c b/src/input/decoder.c
index 7787e7d..159682d 100644
--- a/src/input/decoder.c
+++ b/src/input/decoder.c
@@ -337,7 +337,7 @@ void input_DecoderDecode( decoder_t *p_dec, block_t *p_block )
     if( p_owner->p_input->p->b_out_pace_control )
     {
         /* FIXME !!!!! */
-        while( vlc_object_alive( p_dec ) && !p_dec->b_error &&
+        while( vlc_object_alive( p_dec ) &&
                block_FifoCount( p_owner->p_fifo ) > 10 )
         {
             msleep( 1000 );




More information about the vlc-devel mailing list