[vlc-devel] [PATCH] Added support for ATSC QAM for United States digital cable

[Jean-Baptiste Kempf]

On Thu, Oct 23, 2008 at 12:07:26AM +0200, Christophe Mutricy wrote :
> On Tue, Oct 21, 08 at 09:52 -0400, Charles R. Hordis wrote:
> >      switch( var_GetInteger( p_access, "dvb-modulation" ) )
> >      {
> > +        case 0:     return QAM_AUTO;
> >          case 8:     return VSB_8;
> [...]
> > +        case 256:   return QAM_256;
> >          default:
> >              msg_Dbg( p_access, "ATSC modulation not set, using VSB 8");
> >              return VSB_8;
> 
> As the default value for dvb-modulation is 0, we're changing the default
> behaviour.
> I don't know the dvb kenel code and it sounds like QUAM_AUTO is a
> smarter default than just picking a modulation.
> 
> So 2 questions:
> Is QAM_AUTO really smart ?
> Should we change default: to QAM_AUTO?

MAybe you should mail him directly ?


Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/