[vlc-devel] [PATCH][SoC]OpenGL shader support aka GLSL

[Derk-Jan Hartman]

On 31 aug 2008, at 21:51, Kaarlo Räihä wrote:
> As part of my GSoC, I added OpenGL shader support to OpenGL video  
> output module.
> 1. It is possible to crash OpenGL with certain shader, it might also  
> be possible to cause buffer overflow by abusing evil shader. So if  
> we let people write their custom shader (or load them from text  
> files), they might crash VLC and some very evil people could use  
> them as attack vector. If people can't create shaders freely, nobody  
> will want to create them.

We can require that the user is asked to approve shader loading. The  
first time he wants to do this. That way, it should be as "safe" as  
any other external plugin a person loads.

> 2. Do we just enable basic file loading or Media Player Classic  
> style integrated shader editor?
> http://img152.imageshack.us/img152/3238/mpcshadersupportmy2.png
>
> I will do shader support for DirectX 3D output also, so I hope to  
> get some guidelines now.
>
> (I am not official VLC developer so I hope me using term we for devs  
> don't offend anyone)

I truly doubt that anyone would be offended :D

DJ