[vlc-devel] commit: Fix a crash that happens if you play with video filters. ( Jean-Baptiste Kempf )

git version control git at videolan.org
Fri Sep 5 10:05:36 CEST 2008


vlc | branch: 0.9-bugfix | Jean-Baptiste Kempf <jb at videolan.org> | Fri Sep  5 01:07:09 2008 -0700| [c876401791144309d2427214d818a34198238358] | committer: Jean-Baptiste Kempf 

Fix a crash that happens if you play with video filters.

Crash happens if you do:
 - Play item
 - Activate vfilter
 - Stop item
 - Deactivate vfilter... BooM.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c876401791144309d2427214d818a34198238358
---

 modules/gui/qt4/components/extended_panels.cpp |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/modules/gui/qt4/components/extended_panels.cpp b/modules/gui/qt4/components/extended_panels.cpp
index 8accbf9..04d07f1 100644
--- a/modules/gui/qt4/components/extended_panels.cpp
+++ b/modules/gui/qt4/components/extended_panels.cpp
@@ -343,6 +343,10 @@ void ExtVideo::ChangeVFiltersString( char *psz_name, bool b_add )
     if( THEMIM->getInput() )
         p_vout = ( vout_thread_t * )vlc_object_find( THEMIM->getInput(),
                 VLC_OBJECT_VOUT, FIND_CHILD );
+    /* If you have stopped the video, p_vout is still at its old value */
+    else
+        p_vout = NULL;
+
     if( p_vout )
     {
         if( !strcmp( psz_filter_type, "sub-filter" ) )




More information about the vlc-devel mailing list