[vlc-devel] [PATCH][SoC] Qt improvements

[Rémi Denis-Courmont]

Le samedi 6 septembre 2008 01:04:58 Lukas Durfina, vous avez écrit :
> On Fri, 05 Sep 2008 17:17:23 +0200, Rémi Denis-Courmont <rem at videolan.org>
>
> wrote:
> > Le lundi 1 septembre 2008 20:42:59 Lukas Durfina, vous avez écrit :
> >> There is repaired patch.
> >> - item in enum was moved at the end to not break ABI
> >> - I use macro VLC_OBJECT
> >
> > Hmm, this patch seems to introduce some suspicious looking pointer cast
> > warnings.
>
> Do you think that:
> ../../src/control/video.c: In function 'libvlc_video_filter_remove':
> ../../src/control/video.c:421: warning: passing argument 1 of 'free'
> discards qualifiers from pointer target type
> ../../src/control/audio.c: In function 'libvlc_audio_filter_set_parameter':
> ../../src/control/audio.c:576: warning: unused parameter 'p_e'
> ../../src/control/media_player.c: In function
> 'libvlc_media_player_destroy':
> ../../src/control/media_player.c:489: warning: passing argument 1 of
> 'free' discards qualifiers from pointer target type
>
> mainly first and last ? (Now I have fixed that all ^^^)
>
> Or something other? Because I didnt get any other warnings related to my
> code.

Yes. And then I would rather Pierre reviewed this than I.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary