[vlc-devel] [PATCH] Support VOUT_ASPECT_CHANGE in deinterlace filter

[Laurent Aimar]

On Fri, Sep 12, 2008, Marian ??urkovi?? wrote:
> > You could probably simply use
> >  p_sys->p_vout = vout_Request( p_vout, p_sys->p_vout, &p_vout->fmt_in )
> > and everything should be done for you.
> > 
> > Could you test and report back ?
> Hmm, it's behaves strange.
My bad, I missed an important part.
p_vout->fmt_* should still be updated as in your patch.
Then you have to call
 p_sys->p_vout = vout_Request( p_vout, p_sys->p_vout, &p_vout->fmt_out);
(note that it is fmt_out).

You cannot, in any case, touch p_vout fields if it is not yourself,
ie p_vout is ok, p_sys->p_vout is not (as you miss at least proper
locking).

-- 
fenrir