[vlc-devel] commit: Remove unsafe use of b_dead. ( Rémi Denis-Courmont )

git version control git at videolan.org
Sun Sep 14 13:39:12 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Sun Sep 14 14:41:53 2008 +0300| [a1440bea8dad7c090e7b779f598d6f9589230757] | committer: Rémi Denis-Courmont 

Remove unsafe use of b_dead.

Fortunately, var_DelCallback does the job properly already.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a1440bea8dad7c090e7b779f598d6f9589230757
---

 modules/misc/audioscrobbler.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/modules/misc/audioscrobbler.c b/modules/misc/audioscrobbler.c
index 3a3a1b3..85746be 100644
--- a/modules/misc/audioscrobbler.c
+++ b/modules/misc/audioscrobbler.c
@@ -227,7 +227,6 @@ static void Close( vlc_object_t *p_this )
         pl_Release( p_intf );
     }
 
-    p_intf->b_dead = true;
     int i;
     for( i = 0; i < p_sys->i_songs; i++ )
         DeleteSong( &p_sys->p_queue[i] );
@@ -470,9 +469,6 @@ static int PlayingChange( vlc_object_t *p_this, const char *psz_var,
 
     VLC_UNUSED( p_this ); VLC_UNUSED( psz_var );
 
-    if( p_intf->b_dead )
-        return VLC_SUCCESS;
-
     if( p_sys->b_meta_read == false && newval.i_int >= PLAYING_S )
     {
         ReadMetaData( p_intf );
@@ -505,9 +501,6 @@ static int ItemChange( vlc_object_t *p_this, const char *psz_var,
     VLC_UNUSED( p_this ); VLC_UNUSED( psz_var );
     VLC_UNUSED( oldval ); VLC_UNUSED( newval );
 
-    if( p_intf->b_dead )
-        return VLC_SUCCESS;
-
     p_sys->b_state_cb       = false;
     p_sys->b_meta_read      = false;
     p_sys->b_submit         = false;




More information about the vlc-devel mailing list