[vlc-devel] commit: es_format: Robustification of es_format_copy to avoid a crash reported by Apple-bugreport . (Pierre d'Herbemont )

[Pierre d'Herbemont]

On Wed, Sep 17, 2008 at 10:00 AM, Rémi Denis-Courmont
<rdenis at simphalempin.com> wrote:
>
> On Wed, 17 Sep 2008 00:46:59 +0200 (CEST), git at videolan.org (git version
> control) wrote:
>> vlc | branch: master | Pierre d'Herbemont <pdherbemont at videolan.org> |
> Wed
>> Sep 17 00:49:37 2008 +0200| [fedbcd7fce5f4d931a7d50c52ce6ff900a68454d] |
>> committer: Pierre d'Herbemont
>>
>> es_format: Robustification of es_format_copy to avoid a crash reported by
>> Apple-bugreport.
>
> Looks like a hack to work around the real bug. i_extra cannot be non-zero
> if p_extra is.

Yes, it unfortunately is. We could assert too, but unfortunately
assert() aren't enabled in release mode.

This patch adds also fallback in case malloc() failed.

Pierre.