[vlc-devel] [PATCH] Ignore comments in subtitles

[Michael Meeuwisse]

On Sep 16, 2008, at 14:31, Derk-Jan Hartman wrote:

[nice explanation]

> Next, the patch is just plain wrong. It says:
>
> IF 2nd char is '{' THEN IF the first char is '\' -> skip until we  
> reach the end of the line or we encounter } ELSE print { and skip  
> two chars. } ENDIF ENDIF
> This simply is wrong.
>
> If anything should be changed then it should skip {anything} and NOT  
> skip \{anything} (Where i assume that \ can escape { so that it is  
> still a usable character.

Yeah, already realized this myself but was told on IRC that this is  
old code, and not actually being used anymore for the subtitles. With  
the new 0.9.2 the subs seem to work correctly except when they're  
italic which is a problem probably somewhere else entirely. So just  
ignore previous email. :)


Michael