[vlc-devel] [PATCH] udp : allow 0 ttl value

[Rémi Denis-Courmont]

Le vendredi 19 septembre 2008 16:52:54 Sébastien Escudier, vous avez écrit :
> > Well... POSIX and IETF do specify -1 as the default value, but I suspect
> > much of VLC uses 0 for that. This has the potential to break stuff.
>
> My patch modifies net_ConnectDgram.
> Each time this function is called, it is with a default value of -1, except
> one time :
> It is called through "static inline int net_ConnectUDP" in vlc_network.h
>
> I found five occurences of net_ConnectUDP, in whole vlc source code.
> And 3 of them was a call with 0 value, so I replaced it with -1 in this new
> patch.
>
> It should be safe now, no ?

Maybe, I don't know. What about users who have 0 in their configuration as the 
old default value, if any.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary