[vlc-devel] vlc-devel Digest, Vol 16, Issue 196
Sofia Kunin - Rosslare Security
sofia.kunin at rosslaresecurity.com
Sun Sep 21 14:55:50 CEST 2008
Hello,
Your PC is in loop. It send me 20 messges per day. Please stop it.
Best regards, Sofia
----- Original Message -----
From: <vlc-devel-request at videolan.org>
To: <vlc-devel at videolan.org>
Sent: Sunday, September 21, 2008 12:27 PM
Subject: vlc-devel Digest, Vol 16, Issue 196
> Send vlc-devel mailing list submissions to
> vlc-devel at videolan.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://mailman.videolan.org/listinfo/vlc-devel
> or, via email, send a message with subject or body 'help' to
> vlc-devel-request at videolan.org
>
> You can reach the person managing the list at
> vlc-devel-owner at videolan.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of vlc-devel digest..."
>
>
> Today's Topics:
>
> 1. Re: Gsoc 2008 timeshift patch 1 (Pierre d'Herbemont)
> 2. commit: Minor simplification ( R?mi Denis-Courmont )
> (git version control)
> 3. commit: GC: assert pf_destructor ( R?mi Denis-Courmont )
> (git version control)
> 4. commit: module_t: use GC subsystem instead of objects ( R?mi
> Denis-Courmont ) (git version control)
> 5. commit: New type-safe API for modules listing ( R?mi
> Denis-Courmont ) (git version control)
> 6. commit: Remove the vlc_list_find/module hack ( R?mi
> Denis-Courmont ) (git version control)
> 7. commit: fix symbols list ( R?mi Denis-Courmont )
> (git version control)
> 8. commit: Merge module_release and module_Put ( R?mi
> Denis-Courmont ) (git version control)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sun, 21 Sep 2008 12:23:38 +0200
> From: "Pierre d'Herbemont" <pdherbemont at free.fr>
> Subject: Re: [vlc-devel] Gsoc 2008 timeshift patch 1
> To: "Mailing list for VLC media player developers"
> <vlc-devel at videolan.org>
> Message-ID:
> <e761307d0809210323m4a121d79va733542828fec45d at mail.gmail.com>
> Content-Type: text/plain; charset=ISO-8859-1
>
> Thanks Dylan,
>
> Some small comments on minor issues (a simple git commit -a -m "small
> modif" and git rebase -i will easily merge you those modification
> requests).
>
>> msg_Err(p_access,"I am the Timeshifter!");
>
> There are a lot of msg_Err() like thise one that should now be msg_Dbg().
>
>> //should be enomem
>> return VLC_EGENERIC;
>
> Why that?
>
>> for( i = 0;i < p_sys->i_files;i++)
>> for( i = 0; i < p_sys->i_files; i++ )
>
> Spacing are not consistents here.
>
> Same here:
>
>> + }
>> }
>> + msleep(150);
>> +
>> + //msg_Err(p_access,"crit");
>> + int i;
>> + /* If FIFO empty AND no data left, try slow down the input*/
>> + if((block_FifoSize( p_sys->p_fifo) < TIMESHIFT_FIFO_CRITICAL)
>> &&
>> + (p_sys->i_current_read == p_sys->i_current_write) &&
>> + !p_access->b_die)
>> + {
>
>> + input_thread_t *p_input = vlc_object_find( p_access,
>> VLC_OBJECT_INPUT, FIND_ANYWHERE );
>
> This should be FIND_PARENT, I think. vlc_object_find is now deprecated
> but I guess you don't have much alternative for the moment.
>
> + //p_sys->i_rate_adjustment =
> There are a lot of commented code. What about removing them, or
> hinting on why they are here?
>
> That's all for my quite superficial review :)
>
> Pierre.
>
> On Sun, Sep 21, 2008 at 11:35 AM, Dylan Yudaken <dyudaken at gmail.com>
> wrote:
>> Hi everyone,
>>
>> here is the patch for the timeshift module rewrite I did for the google
>> summer of code.
>>
>> its quite a lot more stable (if you fast forward past the end it doesnt
>> break completely), and could be able to seek in certain situations.
>>
>> The other part of my project ( a lot bigger ) will take some work to get
>> ready for submission
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> http://mailman.videolan.org/listinfo/vlc-devel
>>
>>
>
>
> ------------------------------
>
> Message: 2
> Date: Sun, 21 Sep 2008 12:27:25 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: Minor simplification ( R?mi
> Denis-Courmont )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080921102725.F325423A32 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: master | R?mi Denis-Courmont <rdenis at simphalempin.com> | Sun
> Sep 21 11:19:14 2008 +0300| [db0e6cf93ece7a1be71a75805a979bc6f7df8ba0] |
> committer: R?mi Denis-Courmont
>
> Minor simplification
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=db0e6cf93ece7a1be71a75805a979bc6f7df8ba0
> ---
>
> src/modules/modules.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/modules/modules.c b/src/modules/modules.c
> index 3b88650..9970f03 100644
> --- a/src/modules/modules.c
> +++ b/src/modules/modules.c
> @@ -560,8 +560,7 @@ found_shortcut:
> if( p_new_module )
> {
> CacheMerge( p_this, p_module, p_new_module );
> - vlc_object_attach( p_new_module, p_module );
> - DeleteModule( p_new_module, true );
> + DeleteModule( p_new_module, false );
> }
> }
> #endif
>
>
>
> ------------------------------
>
> Message: 3
> Date: Sun, 21 Sep 2008 12:27:26 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: GC: assert pf_destructor ( R?mi
> Denis-Courmont )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080921102726.0F2FB23A89 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: master | R?mi Denis-Courmont <rdenis at simphalempin.com> | Sun
> Sep 21 12:56:23 2008 +0300| [cc2d7b41b499a24ca4c9575f611e9d0b35f38219] |
> committer: R?mi Denis-Courmont
>
> GC: assert pf_destructor
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=cc2d7b41b499a24ca4c9575f611e9d0b35f38219
> ---
>
> src/libvlc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/libvlc.c b/src/libvlc.c
> index 4fce0d9..3a7c407 100644
> --- a/src/libvlc.c
> +++ b/src/libvlc.c
> @@ -126,6 +126,8 @@ static bool b_daemon = false;
> */
> void *vlc_gc_init (gc_object_t *p_gc, void (*pf_destruct) (gc_object_t *))
> {
> + /* There is no point in using the GC if there is destructor... */
> + assert (pf_destruct);
> p_gc->pf_destructor = pf_destruct;
>
> p_gc->refs = 1;
>
>
>
> ------------------------------
>
> Message: 4
> Date: Sun, 21 Sep 2008 12:27:26 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: module_t: use GC subsystem instead of
> objects ( R?mi Denis-Courmont )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080921102726.4F51A23A99 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: master | R?mi Denis-Courmont <rdenis at simphalempin.com> | Sun
> Sep 21 13:06:03 2008 +0300| [fd0f3ec33c7bdfb15217f7c3eaf171c6045135ee] |
> committer: R?mi Denis-Courmont
>
> module_t: use GC subsystem instead of objects
>
> Modules have no threads, no variables (!= config items) and
> no plugin instances...
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fd0f3ec33c7bdfb15217f7c3eaf171c6045135ee
> ---
>
> src/modules/cache.c | 24 ++++----
> src/modules/entry.c | 65 +++++++++++++++----
> src/modules/modules.c | 165
> +++++++++++++++++++++++++++++++------------------
> src/modules/modules.h | 20 ++++++-
> 4 files changed, 188 insertions(+), 86 deletions(-)
>
> Diff:
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=fd0f3ec33c7bdfb15217f7c3eaf171c6045135ee
>
>
> ------------------------------
>
> Message: 5
> Date: Sun, 21 Sep 2008 12:27:26 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: New type-safe API for modules listing (
> R?mi Denis-Courmont )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080921102726.6A96223A40 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: master | R?mi Denis-Courmont <rdenis at simphalempin.com> | Sun
> Sep 21 13:07:28 2008 +0300| [460a78baf1f189de5d4178df31dc229ac1e366ca] |
> committer: R?mi Denis-Courmont
>
> New type-safe API for modules listing
>
> module_list_get(): gets the list of modules
> module_list_free(): releases the list
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=460a78baf1f189de5d4178df31dc229ac1e366ca
> ---
>
> include/vlc_modules.h | 3 +++
> src/config/cmdline.c | 25 ++++++++-----------------
> src/config/core.c | 23 ++++++++++-------------
> src/config/file.c | 42 ++++++++++++++++++------------------------
> src/libvlc.c | 25 ++++++++++---------------
> src/libvlccore.sym | 2 ++
> 6 files changed, 51 insertions(+), 69 deletions(-)
>
> Diff:
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=460a78baf1f189de5d4178df31dc229ac1e366ca
>
>
> ------------------------------
>
> Message: 6
> Date: Sun, 21 Sep 2008 12:27:26 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: Remove the vlc_list_find/module hack (
> R?mi Denis-Courmont )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080921102726.8320D23AB7 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: master | R?mi Denis-Courmont <rdenis at simphalempin.com> | Sun
> Sep 21 13:09:51 2008 +0300| [fe41cd6050f39ab989cd8183b7755e8d2208e174] |
> committer: R?mi Denis-Courmont
>
> Remove the vlc_list_find/module hack
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fe41cd6050f39ab989cd8183b7755e8d2208e174
> ---
>
> src/misc/objects.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/src/misc/objects.c b/src/misc/objects.c
> index 52b766e..af215e2 100644
> --- a/src/misc/objects.c
> +++ b/src/misc/objects.c
> @@ -817,12 +817,6 @@ vlc_list_t * __vlc_list_find( vlc_object_t *p_this,
> int i_type, int i_mode )
> switch( i_mode & 0x000f )
> {
> case FIND_ANYWHERE:
> - /* Modules should probably not be object, and the module should
> perhaps
> - * not be shared across LibVLC instances. In the mean time, this
> ugly
> - * hack is brought to you by Courmisch. */
> - if (i_type == VLC_OBJECT_MODULE)
> - return vlc_list_find ((vlc_object_t *)p_module_bank,
> - i_type, FIND_CHILD);
> return vlc_list_find (p_this->p_libvlc, i_type, FIND_CHILD);
>
> case FIND_CHILD:
>
>
>
> ------------------------------
>
> Message: 7
> Date: Sun, 21 Sep 2008 12:27:26 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: fix symbols list ( R?mi Denis-Courmont )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080921102726.AA06A23AC3 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: master | R?mi Denis-Courmont <rdenis at simphalempin.com> | Sun
> Sep 21 13:30:34 2008 +0300| [0a1539f53569c28dc35976b6e5302c89c5c683bb] |
> committer: R?mi Denis-Courmont
>
> fix symbols list
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0a1539f53569c28dc35976b6e5302c89c5c683bb
> ---
>
> src/libvlccore.sym | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/src/libvlccore.sym b/src/libvlccore.sym
> index 3d52504..af04613 100644
> --- a/src/libvlccore.sym
> +++ b/src/libvlccore.sym
> @@ -305,21 +305,21 @@ playlist_RecursiveNodeSort
> playlist_ServicesDiscoveryAdd
> playlist_ServicesDiscoveryRemove
> playlist_TreeMove
> -__pl_Release
> __pl_Hold
> +__pl_Release
> resolve_xml_special_chars
> sdp_AddAttribute
> sdp_AddMedia
> secstotimestr
> services_discovery_AddItem
> services_discovery_Create
> -services_discovery_Start
> -services_discovery_Stop
> services_discovery_EventManager
> services_discovery_GetLocalizedName
> __services_discovery_GetServicesNames
> services_discovery_RemoveItem
> services_discovery_SetLocalizedName
> +services_discovery_Start
> +services_discovery_Stop
> sout_AccessOutControl
> sout_AccessOutDelete
> sout_AccessOutNew
> @@ -375,8 +375,9 @@ stream_vaControl
> __str_format
> __str_format_meta
> str_format_time
> -subpicture_region_New
> +subpicture_region_ChainDelete
> subpicture_region_Delete
> +subpicture_region_New
> tls_ClientCreate
> tls_ClientDelete
> ToLocale
> @@ -477,6 +478,7 @@ __vlc_object_create
> __vlc_object_detach
> __vlc_object_find
> vlc_object_find_name
> +__vlc_object_hold
> __vlc_object_kill
> __vlc_object_lock
> __vlc_object_release
> @@ -485,7 +487,6 @@ __vlc_object_signal_unlocked
> __vlc_object_unlock
> __vlc_object_wait
> __vlc_object_waitpipe
> -__vlc_object_hold
> vlc_poll
> vlc_rand_bytes
> vlc_recvmsg
>
>
>
> ------------------------------
>
> Message: 8
> Date: Sun, 21 Sep 2008 12:27:26 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: Merge module_release and module_Put (
> R?mi Denis-Courmont )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080921102726.96A8423A69 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: master | R?mi Denis-Courmont <rdenis at simphalempin.com> | Sun
> Sep 21 13:18:34 2008 +0300| [2ba61deea6a7a177eedee4e66c78b51a7677f942] |
> committer: R?mi Denis-Courmont
>
> Merge module_release and module_Put
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2ba61deea6a7a177eedee4e66c78b51a7677f942
> ---
>
> include/vlc_modules.h | 3 +-
> .../gui/qt4/components/complete_preferences.cpp | 2 +-
> modules/gui/qt4/components/extended_panels.cpp | 4 +-
> modules/gui/qt4/components/open_panels.cpp | 2 +-
> modules/gui/qt4/components/preferences_widgets.cpp | 2 +-
> modules/gui/wxwidgets/dialogs/open.cpp | 8 ++--
> modules/gui/wxwidgets/dialogs/preferences.cpp | 2 +-
> src/libvlccore.sym | 3 +-
> src/modules/modules.c | 34
> +++++++------------
> src/modules/modules.h | 11 ------
> 10 files changed, 27 insertions(+), 44 deletions(-)
>
> diff --git a/include/vlc_modules.h b/include/vlc_modules.h
> index 7d96a35..5b3bb42 100644
> --- a/include/vlc_modules.h
> +++ b/include/vlc_modules.h
> @@ -39,11 +39,12 @@ VLC_EXPORT( bool, __module_Exists, ( vlc_object_t *,
> const char * ) );
>
> #define module_Find(a,b) __module_Find(VLC_OBJECT(a),b)
> VLC_EXPORT( module_t *, __module_Find, ( vlc_object_t *, const char * ) );
> -VLC_EXPORT( void, module_Put, ( module_t *module ) );
>
> VLC_EXPORT( module_config_t *, module_GetConfig, ( const module_t *,
> unsigned * ) );
> VLC_EXPORT( void, module_PutConfig, ( module_config_t * ) );
>
> +VLC_EXPORT( module_t *, module_hold, (module_t *module) );
> +VLC_EXPORT( void, module_release, (module_t *module) );
> VLC_EXPORT( void, module_list_free, (module_t **) );
> VLC_EXPORT( module_t **, module_list_get, (size_t *n) );
>
> diff --git a/modules/gui/qt4/components/complete_preferences.cpp
> b/modules/gui/qt4/components/complete_preferences.cpp
> index 6967290..f543a82 100644
> --- a/modules/gui/qt4/components/complete_preferences.cpp
> +++ b/modules/gui/qt4/components/complete_preferences.cpp
> @@ -496,7 +496,7 @@ AdvPrefsPanel::AdvPrefsPanel( intf_thread_t *_p_intf,
> QWidget *_parent,
> layout->addWidget( box, i_line, 0, 1, -1 );
> }
>
> - module_Put( p_module );
> + module_release (p_module);
>
> scrolled_area->setSizePolicy(
> QSizePolicy::Preferred,QSizePolicy::Fixed );
> scrolled_area->setLayout( layout );
> diff --git a/modules/gui/qt4/components/extended_panels.cpp
> b/modules/gui/qt4/components/extended_panels.cpp
> index ab69ced..2843b3b 100644
> --- a/modules/gui/qt4/components/extended_panels.cpp
> +++ b/modules/gui/qt4/components/extended_panels.cpp
> @@ -271,11 +271,11 @@ void ExtVideo::ChangeVFiltersString( char *psz_name,
> bool b_add )
> }
> else
> {
> - module_Put( p_obj );
> + module_release (p_obj);
> msg_Err( p_intf, "Unknown video filter type." );
> return;
> }
> - module_Put( p_obj );
> + module_release (p_obj);
>
> psz_string = config_GetPsz( p_intf, psz_filter_type );
>
> diff --git a/modules/gui/qt4/components/open_panels.cpp
> b/modules/gui/qt4/components/open_panels.cpp
> index acabe6f..7342a5f 100644
> --- a/modules/gui/qt4/components/open_panels.cpp
> +++ b/modules/gui/qt4/components/open_panels.cpp
> @@ -1214,6 +1214,6 @@ void CaptureOpenPanel::advancedDialog()
> }
> delete adv;
> module_PutConfig( p_config );
> - module_Put( p_module );
> + module_release (p_module);
> }
>
> diff --git a/modules/gui/qt4/components/preferences_widgets.cpp
> b/modules/gui/qt4/components/preferences_widgets.cpp
> index 4f3757a..22337fa 100644
> --- a/modules/gui/qt4/components/preferences_widgets.cpp
> +++ b/modules/gui/qt4/components/preferences_widgets.cpp
> @@ -1196,7 +1196,7 @@ void KeySelectorControl::finish()
> }
> }
> module_PutConfig (p_config);
> - module_Put (p_main);
> + module_release (p_main);
>
> table->resizeColumnToContents( 0 );
>
> diff --git a/modules/gui/wxwidgets/dialogs/open.cpp
> b/modules/gui/wxwidgets/dialogs/open.cpp
> index 7ef0197..f876672 100644
> --- a/modules/gui/wxwidgets/dialogs/open.cpp
> +++ b/modules/gui/wxwidgets/dialogs/open.cpp
> @@ -515,7 +515,7 @@ OpenDialog::OpenDialog( intf_thread_t *_p_intf,
> wxWindow *_p_parent,
> input_tab_array.Add( autopanel );
> notebook->AddPage( autopanel, wxU( module_GetName(p_module, 0) ),
> i_access_method == CAPTURE_ACCESS );
> - module_Put( p_module );
> + module_release (p_module);
> }
>
> p_module = module_Find( VLC_OBJECT(p_intf), "pvr" );
> @@ -526,7 +526,7 @@ OpenDialog::OpenDialog( intf_thread_t *_p_intf,
> wxWindow *_p_parent,
> input_tab_array.Add( autopanel );
> notebook->AddPage( autopanel, wxU( module_GetName(p_module, 0) ),
> i_access_method == CAPTURE_ACCESS );
> - module_Put( p_module );
> + module_release (p_module);
> }
>
> p_module = module_Find( VLC_OBJECT(p_intf), "dvb" );
> @@ -537,7 +537,7 @@ OpenDialog::OpenDialog( intf_thread_t *_p_intf,
> wxWindow *_p_parent,
> input_tab_array.Add( autopanel );
> notebook->AddPage( autopanel, wxU( module_GetName(p_module, 0) ),
> i_access_method == CAPTURE_ACCESS );
> - module_Put( p_module );
> + module_release (p_module);
> }
>
> p_module = module_Find( VLC_OBJECT(p_intf), "dshow" );
> @@ -548,7 +548,7 @@ OpenDialog::OpenDialog( intf_thread_t *_p_intf,
> wxWindow *_p_parent,
> input_tab_array.Add( autopanel );
> notebook->AddPage( autopanel, wxU( module_GetName(p_module, 0) ),
> i_access_method == CAPTURE_ACCESS );
> - module_Put( p_module );
> + module_release (p_module);
> }
>
> /* Update Disc panel */
> diff --git a/modules/gui/wxwidgets/dialogs/preferences.cpp
> b/modules/gui/wxwidgets/dialogs/preferences.cpp
> index edf7de7..6137848 100644
> --- a/modules/gui/wxwidgets/dialogs/preferences.cpp
> +++ b/modules/gui/wxwidgets/dialogs/preferences.cpp
> @@ -1033,7 +1033,7 @@ PrefsPanel::PrefsPanel( wxWindow* parent,
> intf_thread_t *_p_intf,
>
> if( config_data->i_type == TYPE_MODULE )
> {
> - module_Put( p_module );
> + module_release (p_module);
> }
> else
> {
> diff --git a/src/libvlccore.sym b/src/libvlccore.sym
> index 466adfb..3d52504 100644
> --- a/src/libvlccore.sym
> +++ b/src/libvlccore.sym
> @@ -211,12 +211,13 @@ module_GetHelp
> __module_GetModulesNamesForCapability
> module_GetName
> module_GetObjName
> +module_hold
> module_IsCapable
> module_list_free
> module_list_get
> __module_Need
> -module_Put
> module_PutConfig
> +module_release
> __module_Unneed
> __msg_Dbg
> __msg_DisableObjectPrinting
> diff --git a/src/modules/modules.c b/src/modules/modules.c
> index a1a3bdd..c73c97d 100644
> --- a/src/modules/modules.c
> +++ b/src/modules/modules.c
> @@ -325,6 +325,17 @@ const char *module_GetHelp( const module_t *m )
> return m->psz_help;
> }
>
> +module_t *module_hold (module_t *m)
> +{
> + vlc_hold (&m->vlc_gc_data);
> + return m;
> +}
> +
> +void module_release (module_t *m)
> +{
> + vlc_release (&m->vlc_gc_data);
> +}
> +
> /**
> * Frees the flat list of VLC modules.
> * @param list list obtained by module_list_get
> @@ -749,19 +760,6 @@ module_t *__module_Find( vlc_object_t *p_this, const
> char * psz_name )
> return module;
> }
>
> -
> -/**
> - * Release a module_t pointer from module_Find().
> - *
> - * \param module the module to release
> - * \return nothing
> - */
> -void module_Put( module_t *module )
> -{
> - module_release( module );
> -}
> -
> -
> /**
> * Tell if a module exists and release it in thic case
> *
> @@ -773,14 +771,8 @@ bool __module_Exists( vlc_object_t *p_this, const
> char * psz_name )
> {
> module_t *p_module = __module_Find( p_this, psz_name );
> if( p_module )
> - {
> - module_Put( p_module );
> - return true;
> - }
> - else
> - {
> - return false;
> - }
> + module_release (p_module);
> + return true != NULL;
> }
>
> /**
> diff --git a/src/modules/modules.h b/src/modules/modules.h
> index 2f9de5b..baafe45 100644
> --- a/src/modules/modules.h
> +++ b/src/modules/modules.h
> @@ -149,17 +149,6 @@ struct module_t
> bool b_loaded; /* Set to true if the dll is loaded */
> };
>
> -static inline module_t *module_hold (module_t *m)
> -{
> - vlc_hold (&m->vlc_gc_data);
> - return m;
> -}
> -
> -static inline void module_release (module_t *m)
> -{
> - vlc_release (&m->vlc_gc_data);
> -}
> -
> #define module_InitBank(a) __module_InitBank(VLC_OBJECT(a))
> void __module_InitBank ( vlc_object_t * );
> #define module_LoadBuiltins(a) __module_LoadBuiltins(VLC_OBJECT(a))
>
>
>
> ------------------------------
>
> _______________________________________________
> vlc-devel mailing list
> vlc-devel at videolan.org
> http://mailman.videolan.org/listinfo/vlc-devel
>
>
> End of vlc-devel Digest, Vol 16, Issue 196
> ******************************************
>
More information about the vlc-devel
mailing list