[vlc-devel] vlc-devel Digest, Vol 16, Issue 206

Sofia Kunin - Rosslare Security sofia.kunin at rosslaresecurity.com
Mon Sep 22 12:51:46 CEST 2008


Stop the messages, please
----- Original Message ----- 
From: <vlc-devel-request at videolan.org>
To: <vlc-devel at videolan.org>
Sent: Monday, September 22, 2008 10:23 AM
Subject: vlc-devel Digest, Vol 16, Issue 206


> Send vlc-devel mailing list submissions to
> vlc-devel at videolan.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://mailman.videolan.org/listinfo/vlc-devel
> or, via email, send a message with subject or body 'help' to
> vlc-devel-request at videolan.org
>
> You can reach the person managing the list at
> vlc-devel-owner at videolan.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of vlc-devel digest..."
>
>
> Today's Topics:
>
>   1. Re: commit: Qt4: Video Effects: Force puzzle to be in
>      [2:16]x[2:16] range ( Jean-Baptiste Kempf ) (Antoine Cellerier)
>   2. commit: Qt4: Really split the TimeLabel into its own class. (
>      Jean-Baptiste Kempf ) (git version control)
>   3. commit: Qt4: Really split the TimeLabel into its own class. (
>      Jean-Baptiste Kempf ) (git version control)
>   4. Re: commit: Fix GCC error message: undefined reference to
>      `__sync_fetch_and_sub_4` (Jean-Paul Saman ) (Jean-Paul Saman)
>   5. commit: clean-up ( Felix Paul K?hne ) (git version control)
>   6. commit: Clean-up and minor update ( Felix Paul K?hne  )
>      (git version control)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Mon, 22 Sep 2008 00:28:48 +0200
> From: Antoine Cellerier <dionoea at videolan.org>
> Subject: Re: [vlc-devel] commit: Qt4: Video Effects: Force puzzle to
> be in [2:16]x[2:16] range ( Jean-Baptiste Kempf )
> To: vlc-devel at videolan.org
> Message-ID: <20080921222848.GC888 at chewa.net>
> Content-Type: text/plain; charset=utf-8
>
> On Sun, Sep 21, 2008, git version control wrote:
>> Qt4: Video Effects: Force puzzle to be in [2:16]x[2:16] range
>
> Shouldn't this be fixed in the puzzle filter itself instead?
> (you can specify allowed ranges on int variables and config options)
>
> -- 
> Antoine Cellerier
> dionoea
>
>
> ------------------------------
>
> Message: 2
> Date: Mon, 22 Sep 2008 04:46:02 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: Qt4: Really split the TimeLabel into its
> own class. ( Jean-Baptiste Kempf )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080922024602.3796523DE3 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Sun Sep 21 
> 19:46:42 2008 -0700| [44e31c0f861b90a01ff3239354d7b2bf43468d07] | 
> committer: Jean-Baptiste Kempf
>
> Qt4: Really split the TimeLabel into its own class.
>
> Code simplification and TimeLabel in the FSC.
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=44e31c0f861b90a01ff3239354d7b2bf43468d07
> ---
>
> modules/gui/qt4/components/interface_widgets.cpp |   44 
> +++++++++++++++++++++-
> modules/gui/qt4/components/interface_widgets.hpp |   17 ++++++--
> modules/gui/qt4/main_interface.cpp               |   31 +---------------
> modules/gui/qt4/main_interface.hpp               |    3 -
> 4 files changed, 56 insertions(+), 39 deletions(-)
>
> diff --git a/modules/gui/qt4/components/interface_widgets.cpp 
> b/modules/gui/qt4/components/interface_widgets.cpp
> index a77f726..9863b3b 100644
> --- a/modules/gui/qt4/components/interface_widgets.cpp
> +++ b/modules/gui/qt4/components/interface_widgets.cpp
> @@ -1027,6 +1027,7 @@ 
> FullscreenControllerWidget::FullscreenControllerWidget( intf_thread_t 
> *_p_i,
>     fsLayout->addWidget( slider, 0, 1, 1, 9 );
>     fsLayout->addWidget( fasterButton, 0, 10 );
>
> +    /* Second line */
>     fsLayout->addWidget( playButton, 1, 0, 1, 2 );
>     fsLayout->addLayout( controlButLayout, 1, 2 );
>
> @@ -1036,8 +1037,12 @@ 
> FullscreenControllerWidget::FullscreenControllerWidget( intf_thread_t 
> *_p_i,
>     fsLayout->addWidget( advControls, 1, 6, Qt::AlignVCenter );
>
>     fsLayout->setColumnStretch( 7, 10 );
> -    fsLayout->addWidget( volMuteLabel, 1, 8 );
> -    fsLayout->addWidget( volumeSlider, 1, 9, 1, 2 );
> +
> +    TimeLabel *timeLabel = new TimeLabel( p_intf );
> +
> +    fsLayout->addWidget( timeLabel, 1, 8 );
> +    fsLayout->addWidget( volMuteLabel, 1, 9 );
> +    fsLayout->addWidget( volumeSlider, 1, 10,1, 2 );
>
>     /* hiding timer */
>     p_hideTimer = new QTimer( this );
> @@ -1068,6 +1073,7 @@ 
> FullscreenControllerWidget::FullscreenControllerWidget( intf_thread_t 
> *_p_i,
>     fullscreenButton->setIcon( QIcon( ":/defullscreen" ) );
>
>     vlc_mutex_init_recursive( &lock );
> +    setMinimumWidth( 450 );
> }
>
> FullscreenControllerWidget::~FullscreenControllerWidget()
> @@ -1608,3 +1614,37 @@ void CoverArtLabel::doUpdate()
>     }
> }
>
> +TimeLabel::TimeLabel( intf_thread_t *_p_intf  ) :QLabel(), p_intf( 
> _p_intf )
> +{
> +   b_remainingTime = false;
> +   setText( " --:--/--:-- " );
> +   setAlignment( Qt::AlignRight | Qt::AlignVCenter );
> +   setToolTip( qtr( "Toggle between elapsed and remaining time" ) );
> +
> +
> +   CONNECT( THEMIM->getIM(), positionUpdated( float, int, int ),
> +             this, setDisplayPosition( float, int, int ) );
> +}
> +
> +void TimeLabel::setDisplayPosition( float pos, int time, int length )
> +{
> +    char psz_length[MSTRTIME_MAX_SIZE], psz_time[MSTRTIME_MAX_SIZE];
> +    secstotimestr( psz_length, length );
> +    secstotimestr( psz_time, ( b_remainingTime && length ) ? length - 
> time
> +                                                           : time );
> +
> +    QString timestr;
> +    timestr.sprintf( "%s/%s", psz_time,
> +                            ( !length && time ) ? "--:--" : psz_length );
> +
> +    /* Add a minus to remaining time*/
> +    if( b_remainingTime && length ) setText( " -"+timestr+" " );
> +    else setText( " "+timestr+" " );
> +}
> +
> +void TimeLabel::toggleTimeDisplay()
> +{
> +    b_remainingTime = !b_remainingTime;
> +}
> +
> +
> diff --git a/modules/gui/qt4/components/interface_widgets.hpp 
> b/modules/gui/qt4/components/interface_widgets.hpp
> index 1415e4d..9d16946 100644
> --- a/modules/gui/qt4/components/interface_widgets.hpp
> +++ b/modules/gui/qt4/components/interface_widgets.hpp
> @@ -332,16 +332,25 @@ private:
> class TimeLabel : public QLabel
> {
>     Q_OBJECT
> -    void mousePressEvent( QMouseEvent *event )
> +public:
> +    TimeLabel( intf_thread_t *_p_intf );
> +protected:
> +    virtual void mousePressEvent( QMouseEvent *event )
>     {
> -        emit timeLabelClicked();
> +        toggleTimeDisplay();
>     }
> -    void mouseDoubleClickEvent( QMouseEvent *event )
> +    virtual void mouseDoubleClickEvent( QMouseEvent *event )
>     {
> +        toggleTimeDisplay();
>         emit timeLabelDoubleClicked();
>     }
> +private slots:
> +    void setDisplayPosition( float pos, int time, int length );
> +private:
> +    intf_thread_t *p_intf;
> +    bool b_remainingTime;
> +    void toggleTimeDisplay();
> signals:
> -    void timeLabelClicked();
>     void timeLabelDoubleClicked();
> };
>
> diff --git a/modules/gui/qt4/main_interface.cpp 
> b/modules/gui/qt4/main_interface.cpp
> index 017f586..1f69455 100644
> --- a/modules/gui/qt4/main_interface.cpp
> +++ b/modules/gui/qt4/main_interface.cpp
> @@ -146,8 +146,6 @@ MainInterface::MainInterface( intf_thread_t *_p_intf ) 
> : QVLCMW( _p_intf )
>     /* Connect the input manager to the GUI elements it manages */
>
>     /* It is also connected to the control->slider, see the ControlsWidget 
> */
> -    CONNECT( THEMIM->getIM(), positionUpdated( float, int, int ),
> -             this, setDisplayPosition( float, int, int ) );
>     /* Change the SpeedRate in the Status */
>     CONNECT( THEMIM->getIM(), rateChanged( int ), this, setRate( int ) );
>
> @@ -291,11 +289,7 @@ inline void MainInterface::createStatusBar()
>      *  Status Bar  *
>      ****************/
>     /* Widgets Creation*/
> -    b_remainingTime = false;
> -    timeLabel = new TimeLabel;
> -    timeLabel->setText( " --:--/--:-- " );
> -    timeLabel->setAlignment( Qt::AlignRight | Qt::AlignVCenter );
> -    timeLabel->setToolTip( qtr( "Toggle between elapsed and remaining 
> time" ) );
> +    timeLabel = new TimeLabel( p_intf );
>     nameLabel = new QLabel;
>     nameLabel->setTextInteractionFlags( Qt::TextSelectableByMouse
>                                       | Qt::TextSelectableByKeyboard );
> @@ -318,9 +312,7 @@ inline void MainInterface::createStatusBar()
>        - double clicking opens the goto time dialog
>        - right-clicking and clicking just toggle between remaining and
>          elapsed time.*/
> -    CONNECT( timeLabel, timeLabelClicked(), this, toggleTimeDisplay() );
>     CONNECT( timeLabel, timeLabelDoubleClicked(), THEDP, 
> gotoTimeDialog() );
> -    CONNECT( timeLabel, timeLabelDoubleClicked(), this, 
> toggleTimeDisplay() );
>
>     /* Speed Label behaviour:
>        - right click gives the vertical speed slider */
> @@ -854,27 +846,6 @@ void MainInterface::visual()
> /************************************************************************
>  * Other stuff
>  ************************************************************************/
> -void MainInterface::setDisplayPosition( float pos, int time, int length )
> -{
> -    char psz_length[MSTRTIME_MAX_SIZE], psz_time[MSTRTIME_MAX_SIZE];
> -    secstotimestr( psz_length, length );
> -    secstotimestr( psz_time, ( b_remainingTime && length ) ? length - 
> time
> -                                                           : time );
> -
> -    QString timestr;
> -    timestr.sprintf( "%s/%s", psz_time,
> -                            ( !length && time ) ? "--:--" : psz_length );
> -
> -    /* Add a minus to remaining time*/
> -    if( b_remainingTime && length ) timeLabel->setText( " -"+timestr+" 
> " );
> -    else timeLabel->setText( " "+timestr+" " );
> -}
> -
> -void MainInterface::toggleTimeDisplay()
> -{
> -    b_remainingTime = !b_remainingTime;
> -}
> -
> void MainInterface::setName( QString name )
> {
>     input_name = name; /* store it for the QSystray use */
> diff --git a/modules/gui/qt4/main_interface.hpp 
> b/modules/gui/qt4/main_interface.hpp
> index 65c61a3..2d4f57d 100644
> --- a/modules/gui/qt4/main_interface.hpp
> +++ b/modules/gui/qt4/main_interface.hpp
> @@ -133,7 +133,6 @@ private:
>     bool                 playlistVisible; ///< Is the playlist visible ?
>     bool                 visualSelectorEnabled;
>     bool                 notificationEnabled; /// Systray Notifications
> -    bool                 b_remainingTime; /* Show elapsed or remaining 
> time */
>     bool                 bgWasVisible;
>     int                  i_visualmode; ///< Visual Mode
>     pl_dock_e            i_pl_dock;
> @@ -171,8 +170,6 @@ private slots:
>     void setRate( int );
>     void setName( QString );
>     void setVLCWindowsTitle( QString title = "" );
> -    void setDisplayPosition( float, int, int );
> -    void toggleTimeDisplay();
> #if 0
>     void visual();
> #endif
>
>
>
> ------------------------------
>
> Message: 3
> Date: Mon, 22 Sep 2008 04:54:04 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: Qt4: Really split the TimeLabel into its
> own class. ( Jean-Baptiste Kempf )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080922025404.CE8CB23E30 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: 0.9-bugfix | Jean-Baptiste Kempf <jb at videolan.org> | Sun Sep 
> 21 19:46:42 2008 -0700| [4c8750b05bebd4611e80001d59ba21f2ee07c214] | 
> committer: Jean-Baptiste Kempf
>
> Qt4: Really split the TimeLabel into its own class.
>
> Code simplification and TimeLabel in the FSC.
> (cherry picked from commit 44e31c0f861b90a01ff3239354d7b2bf43468d07)
>
> Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4c8750b05bebd4611e80001d59ba21f2ee07c214
> ---
>
> modules/gui/qt4/components/interface_widgets.cpp |   44 
> +++++++++++++++++++++-
> modules/gui/qt4/components/interface_widgets.hpp |   17 ++++++--
> modules/gui/qt4/main_interface.cpp               |   31 +---------------
> modules/gui/qt4/main_interface.hpp               |    3 -
> 4 files changed, 56 insertions(+), 39 deletions(-)
>
> diff --git a/modules/gui/qt4/components/interface_widgets.cpp 
> b/modules/gui/qt4/components/interface_widgets.cpp
> index 4f5b65f..afdffec 100644
> --- a/modules/gui/qt4/components/interface_widgets.cpp
> +++ b/modules/gui/qt4/components/interface_widgets.cpp
> @@ -1040,6 +1040,7 @@ 
> FullscreenControllerWidget::FullscreenControllerWidget( intf_thread_t 
> *_p_i,
>     fsLayout->addWidget( slider, 0, 1, 1, 9 );
>     fsLayout->addWidget( fasterButton, 0, 10 );
>
> +    /* Second line */
>     fsLayout->addWidget( playButton, 1, 0, 1, 2 );
>     fsLayout->addLayout( controlButLayout, 1, 2 );
>
> @@ -1049,8 +1050,12 @@ 
> FullscreenControllerWidget::FullscreenControllerWidget( intf_thread_t 
> *_p_i,
>     fsLayout->addWidget( advControls, 1, 6, Qt::AlignVCenter );
>
>     fsLayout->setColumnStretch( 7, 10 );
> -    fsLayout->addWidget( volMuteLabel, 1, 8 );
> -    fsLayout->addWidget( volumeSlider, 1, 9, 1, 2 );
> +
> +    TimeLabel *timeLabel = new TimeLabel( p_intf );
> +
> +    fsLayout->addWidget( timeLabel, 1, 8 );
> +    fsLayout->addWidget( volMuteLabel, 1, 9 );
> +    fsLayout->addWidget( volumeSlider, 1, 10,1, 2 );
>
>     /* hiding timer */
>     p_hideTimer = new QTimer( this );
> @@ -1081,6 +1086,7 @@ 
> FullscreenControllerWidget::FullscreenControllerWidget( intf_thread_t 
> *_p_i,
>     fullscreenButton->setIcon( QIcon( ":/defullscreen" ) );
>
>     vlc_mutex_init_recursive( &lock );
> +    setMinimumWidth( 450 );
> }
>
> FullscreenControllerWidget::~FullscreenControllerWidget()
> @@ -1619,3 +1625,37 @@ void CoverArtLabel::doUpdate()
>     }
> }
>
> +TimeLabel::TimeLabel( intf_thread_t *_p_intf  ) :QLabel(), p_intf( 
> _p_intf )
> +{
> +   b_remainingTime = false;
> +   setText( " --:--/--:-- " );
> +   setAlignment( Qt::AlignRight | Qt::AlignVCenter );
> +   setToolTip( qtr( "Toggle between elapsed and remaining time" ) );
> +
> +
> +   CONNECT( THEMIM->getIM(), positionUpdated( float, int, int ),
> +             this, setDisplayPosition( float, int, int ) );
> +}
> +
> +void TimeLabel::setDisplayPosition( float pos, int time, int length )
> +{
> +    char psz_length[MSTRTIME_MAX_SIZE], psz_time[MSTRTIME_MAX_SIZE];
> +    secstotimestr( psz_length, length );
> +    secstotimestr( psz_time, ( b_remainingTime && length ) ? length - 
> time
> +                                                           : time );
> +
> +    QString timestr;
> +    timestr.sprintf( "%s/%s", psz_time,
> +                            ( !length && time ) ? "--:--" : psz_length );
> +
> +    /* Add a minus to remaining time*/
> +    if( b_remainingTime && length ) setText( " -"+timestr+" " );
> +    else setText( " "+timestr+" " );
> +}
> +
> +void TimeLabel::toggleTimeDisplay()
> +{
> +    b_remainingTime = !b_remainingTime;
> +}
> +
> +
> diff --git a/modules/gui/qt4/components/interface_widgets.hpp 
> b/modules/gui/qt4/components/interface_widgets.hpp
> index 8335be2..5bfcd1f 100644
> --- a/modules/gui/qt4/components/interface_widgets.hpp
> +++ b/modules/gui/qt4/components/interface_widgets.hpp
> @@ -332,16 +332,25 @@ private:
> class TimeLabel : public QLabel
> {
>     Q_OBJECT
> -    void mousePressEvent( QMouseEvent *event )
> +public:
> +    TimeLabel( intf_thread_t *_p_intf );
> +protected:
> +    virtual void mousePressEvent( QMouseEvent *event )
>     {
> -        emit timeLabelClicked();
> +        toggleTimeDisplay();
>     }
> -    void mouseDoubleClickEvent( QMouseEvent *event )
> +    virtual void mouseDoubleClickEvent( QMouseEvent *event )
>     {
> +        toggleTimeDisplay();
>         emit timeLabelDoubleClicked();
>     }
> +private slots:
> +    void setDisplayPosition( float pos, int time, int length );
> +private:
> +    intf_thread_t *p_intf;
> +    bool b_remainingTime;
> +    void toggleTimeDisplay();
> signals:
> -    void timeLabelClicked();
>     void timeLabelDoubleClicked();
> };
>
> diff --git a/modules/gui/qt4/main_interface.cpp 
> b/modules/gui/qt4/main_interface.cpp
> index 94df454..d629c0d 100644
> --- a/modules/gui/qt4/main_interface.cpp
> +++ b/modules/gui/qt4/main_interface.cpp
> @@ -146,8 +146,6 @@ MainInterface::MainInterface( intf_thread_t *_p_intf ) 
> : QVLCMW( _p_intf )
>     /* Connect the input manager to the GUI elements it manages */
>
>     /* It is also connected to the control->slider, see the ControlsWidget 
> */
> -    CONNECT( THEMIM->getIM(), positionUpdated( float, int, int ),
> -             this, setDisplayPosition( float, int, int ) );
>     /* Change the SpeedRate in the Status */
>     CONNECT( THEMIM->getIM(), rateChanged( int ), this, setRate( int ) );
>
> @@ -300,11 +298,7 @@ inline void MainInterface::createStatusBar()
>      *  Status Bar  *
>      ****************/
>     /* Widgets Creation*/
> -    b_remainingTime = false;
> -    timeLabel = new TimeLabel;
> -    timeLabel->setText( " --:--/--:-- " );
> -    timeLabel->setAlignment( Qt::AlignRight | Qt::AlignVCenter );
> -    timeLabel->setToolTip( qtr( "Toggle between elapsed and remaining 
> time" ) );
> +    timeLabel = new TimeLabel( p_intf );
>     nameLabel = new QLabel;
>     nameLabel->setTextInteractionFlags( Qt::TextSelectableByMouse
>                                       | Qt::TextSelectableByKeyboard );
> @@ -327,9 +321,7 @@ inline void MainInterface::createStatusBar()
>        - double clicking opens the goto time dialog
>        - right-clicking and clicking just toggle between remaining and
>          elapsed time.*/
> -    CONNECT( timeLabel, timeLabelClicked(), this, toggleTimeDisplay() );
>     CONNECT( timeLabel, timeLabelDoubleClicked(), THEDP, 
> gotoTimeDialog() );
> -    CONNECT( timeLabel, timeLabelDoubleClicked(), this, 
> toggleTimeDisplay() );
>
>     /* Speed Label behaviour:
>        - right click gives the vertical speed slider */
> @@ -863,27 +855,6 @@ void MainInterface::visual()
> /************************************************************************
>  * Other stuff
>  ************************************************************************/
> -void MainInterface::setDisplayPosition( float pos, int time, int length )
> -{
> -    char psz_length[MSTRTIME_MAX_SIZE], psz_time[MSTRTIME_MAX_SIZE];
> -    secstotimestr( psz_length, length );
> -    secstotimestr( psz_time, ( b_remainingTime && length ) ? length - 
> time
> -                                                           : time );
> -
> -    QString timestr;
> -    timestr.sprintf( "%s/%s", psz_time,
> -                            ( !length && time ) ? "--:--" : psz_length );
> -
> -    /* Add a minus to remaining time*/
> -    if( b_remainingTime && length ) timeLabel->setText( " -"+timestr+" 
> " );
> -    else timeLabel->setText( " "+timestr+" " );
> -}
> -
> -void MainInterface::toggleTimeDisplay()
> -{
> -    b_remainingTime = !b_remainingTime;
> -}
> -
> void MainInterface::setName( QString name )
> {
>     input_name = name; /* store it for the QSystray use */
> diff --git a/modules/gui/qt4/main_interface.hpp 
> b/modules/gui/qt4/main_interface.hpp
> index 65c61a3..2d4f57d 100644
> --- a/modules/gui/qt4/main_interface.hpp
> +++ b/modules/gui/qt4/main_interface.hpp
> @@ -133,7 +133,6 @@ private:
>     bool                 playlistVisible; ///< Is the playlist visible ?
>     bool                 visualSelectorEnabled;
>     bool                 notificationEnabled; /// Systray Notifications
> -    bool                 b_remainingTime; /* Show elapsed or remaining 
> time */
>     bool                 bgWasVisible;
>     int                  i_visualmode; ///< Visual Mode
>     pl_dock_e            i_pl_dock;
> @@ -171,8 +170,6 @@ private slots:
>     void setRate( int );
>     void setName( QString );
>     void setVLCWindowsTitle( QString title = "" );
> -    void setDisplayPosition( float, int, int );
> -    void toggleTimeDisplay();
> #if 0
>     void visual();
> #endif
>
>
>
> ------------------------------
>
> Message: 4
> Date: Mon, 22 Sep 2008 09:29:29 +0200
> From: Jean-Paul Saman <jpsaman at videolan.org>
> Subject: Re: [vlc-devel] commit: Fix GCC error message: undefined
> reference to `__sync_fetch_and_sub_4` (Jean-Paul Saman )
> To: Mailing list for VLC media player developers
> <vlc-devel at videolan.org>
> Message-ID: <48D74959.7010000 at videolan.org>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> R?mi Denis-Courmont wrote:
>> Le dimanche 21 septembre 2008 20:45:00 git version control, vous avez 
>> ?crit :
>>> vlc | branch: master | Jean-Paul Saman <jpsaman at videolan.org> | Sun Sep 
>>> 21
>>> 19:42:27 2008 +0200| [ce241ca11ac2e2db3a8c312616906e064772fc11] |
>>> committer: Jean-Paul Saman
>>>
>>> Fix GCC error message: undefined reference to `__sync_fetch_and_sub_4`
>>
>> Do you seriously think the buildbots have gcc 4.4? A version which is not
>> published yet? A version which some Debian report said could not yet 
>> build
>> VLC...
>
> It is not only my system that is affected, but DimStar, J-Peg and
> probably others. It affects at least archlinux, fedora 8 and OpenSuSE
> 10.2, 10.3 and 11.0.
>
>> I am sick-tired of your selfish "fixes". If your GCC is that broken that 
>> it
>> does not have the builtin atomics on 386(!) that's not everybody's 
>> problem.
>
> Actually it is everybody's problem except those that are running Debian
> and according to your reasoning it is ok to break vlc building on every
> other platform. What is that for an attitude?
>
> Ah but you just _DO_NOT_ care since your system works !! It means I am
> NOT the one who is selfish but YOU.
>
> Listing to your objections it would be best to revert the commit that
> introduced this problem. Do you happen to know which one that is? Or do
> you not care?
>
> Gtz
> Jean-Paul Saman.
>
>
> ------------------------------
>
> Message: 5
> Date: Mon, 22 Sep 2008 10:23:41 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: clean-up ( Felix Paul K?hne )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080922082341.DA2F722BD8 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: 0.9-bugfix | Felix Paul K?hne <fkuehne at videolan.org> | Mon 
> Sep 22 10:23:53 2008 +0200| [bd4d397c84e52ff7a53927467b51bbf57c2f9954] | 
> committer: Felix Paul K?hne
>
> clean-up
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bd4d397c84e52ff7a53927467b51bbf57c2f9954
> ---
>
> NEWS |   40 +++++++++++++++++++++++-----------------
> 1 files changed, 23 insertions(+), 17 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 2332408..237a0ad 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,28 +1,34 @@
> Changes between 0.9.2 and 0.9.3-git:
> ------------------------------------
>
> - * Fixed sensitivity of Fullscreen Controller on Windows
> - * Fixed ffmpeg slowness on Mac OS X (PowerPC)
> - * Fixed crash on startup on Mac OS X when installed on old preferences
> - * Fixed error messages on startup on Windows when VLC wasn't correctly
> -   uninstalled before installation
> - * Various crashes fixed in PS, SSA, mkv, xspf, freetype
> +Various bugfixes:
>  * Fixed DTS channel order on 5.1 systems
> - * Fixed pausing behaviour for subtitles
> + * Fixed pausing behavior for subtitles
>  * Multiple subtitles and podcast fixes
> + * Various crashes fixed in PS, SSA, mkv, xspf, freetype
> + * Fixed update system bugs
> + * Other bug fixes (dvd language selection, ...)
> +
> +Mac OS X port:
> + * Fixed ffmpeg slowness on PowerPC-based Macs
> + * Fixed crash on startup when installed on old preferences
>  * Fixed bug in directory opening on Mac OS X
> + * Fixed font selection in the Simple Preferences
> + * Thicker border to the subtitle renderer
> + * Fixed the appearance of playlist items in the Streaming/Transcoding 
> Wizard
> + * Fixed AC3 passthrough on Mac OS X
> + * Fixed behavior of the Volume Normalizer settings on Mac OS X
> + * Removed the deprecated QuickDraw video output module to avoid crashes 
> on
> +      modern Mac OS X versions
> +
> +Windows port:
> + * Fixed sensitivity of Fullscreen Controller
> + * Fixed error messages on startup when VLC wasn't correctly uninstalled
> +      before installation
> +
> +Qt4 interface:
>  * Fixed lost playlist columns when switching the playlist view
>  * Added needed options to Simple preferences (to avoid NVIDIA drivers 
> issues)
> - * Fixed font selection on Mac OS X
> - * Thicker border to the Mac OS X subtitle renderer
> - * Fixed update system bugs
> - * Fixed the appereance of playlist items in the Streaming/Transcoding 
> Wizard
> -   (Mac OS X only)
> - * Fixed AC3 passthrough on Mac OS X
> - * Fixed behaviour of the Volume Normalizer settings on Mac OS X
> - * Removed the deprecated QuickDraw video output module to avoid crashes 
> on
> -   modern Mac OS X versions
> - * Other bug fixes (dvd language selection, ...)
>
>
> Changes between 0.9.1 and 0.9.2:
>
>
>
> ------------------------------
>
> Message: 6
> Date: Mon, 22 Sep 2008 10:23:41 +0200 (CEST)
> From: git at videolan.org (git version control)
> Subject: [vlc-devel] commit: Clean-up and minor update ( Felix Paul
> K?hne  )
> To: <vlc-devel at videolan.org>
> Message-ID: <20080922082341.EE41523E80 at skanda.videolan.org>
> Content-Type: text/plain; charset=UTF-8
>
> vlc | branch: 0.9-bugfix | Felix Paul K?hne <fkuehne at videolan.org> | Mon 
> Sep 22 10:27:06 2008 +0200| [78b93574dd754cd19dd3ce09327cdc47248c80da] | 
> committer: Felix Paul K?hne
>
> Clean-up and minor update
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=78b93574dd754cd19dd3ce09327cdc47248c80da
> ---
>
> NEWS |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 237a0ad..399d236 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -19,14 +19,15 @@ Mac OS X port:
>  * Fixed AC3 passthrough on Mac OS X
>  * Fixed behavior of the Volume Normalizer settings on Mac OS X
>  * Removed the deprecated QuickDraw video output module to avoid crashes 
> on
> -      modern Mac OS X versions
> +   modern Mac OS X versions
>
> Windows port:
>  * Fixed sensitivity of Fullscreen Controller
>  * Fixed error messages on startup when VLC wasn't correctly uninstalled
> -      before installation
> +   before installation
>
> Qt4 interface:
> + * Added Faster/Slower buttons to the controller panel
>  * Fixed lost playlist columns when switching the playlist view
>  * Added needed options to Simple preferences (to avoid NVIDIA drivers 
> issues)
>
>
>
>
> ------------------------------
>
> _______________________________________________
> vlc-devel mailing list
> vlc-devel at videolan.org
> http://mailman.videolan.org/listinfo/vlc-devel
>
>
> End of vlc-devel Digest, Vol 16, Issue 206
> ******************************************
> 





More information about the vlc-devel mailing list