[vlc-devel] [RFC] Option whitelisting policy

Rémi Duraffort ivoire at via.ecp.fr
Mon Sep 22 23:22:30 CEST 2008


For the first patch:
>         add_integer( "dvb-voltage", 13, NULL, VOLTAGE_TEXT,
>         VOLTAGE_LONGTEXT,
>              true );
> +            change_safe();
>          add_bool( "dvb-high-voltage", 0, NULL, HIGH_VOLTAGE_TEXT,
>              HIGH_VOLTAGE_LONGTEXT, true );
> +            change_safe();
I don't like the fact the setting the voltage on the dvb card is safe.



>      add_string( "http-proxy", NULL, NULL, PROXY_TEXT, PROXY_LONGTEXT,
>                  false );
> +        change_safe();
>      add_password( "http-proxy-pwd", NULL, NULL,
>                    PROXY_PASS_TEXT, PROXY_PASS_LONGTEXT, false );
> +        change_safe();
>      add_integer( "http-caching", 4 * DEFAULT_PTS_DELAY / 1000, NULL,
>                   CACHING_TEXT, CACHING_LONGTEXT, true );
> +        change_safe();
I'm not sure that a good idea to let this option available as safe !!

-- 
ivoire | Rémi Duraffort



More information about the vlc-devel mailing list