[vlc-devel] commit: VLC_OBJECT_OPENGL: nobody uses _find on this, useless ( Rémi Denis-Courmont )

Pierre d'Herbemont pdherbemont at free.fr
Sun Sep 28 18:29:44 CEST 2008


Actually it is still used by the Mac OS X interface...

On Sun, Sep 28, 2008 at 5:30 PM, git version control <git at videolan.org> wrote:
> vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Sun Sep 28 18:23:36 2008 +0300| [22040d1ebac67aa79dc35b279937cbe0dc183b74] | committer: Rémi Denis-Courmont
>
> VLC_OBJECT_OPENGL: nobody uses _find on this, useless
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=22040d1ebac67aa79dc35b279937cbe0dc183b74
> ---
>
>  modules/video_output/opengl.c           |    5 +----
>  modules/visualization/galaktos/plugin.c |    2 +-
>  2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/modules/video_output/opengl.c b/modules/video_output/opengl.c
> index cb1fe52..3711dde 100644
> --- a/modules/video_output/opengl.c
> +++ b/modules/video_output/opengl.c
> @@ -270,12 +270,9 @@ static int CreateVout( vlc_object_t *p_this )
>
>     /* Get window */
>     p_sys->p_vout =
> -        (vout_thread_t *)vlc_object_create( p_this, VLC_OBJECT_OPENGL );
> +        (vout_thread_t *)vlc_object_create( p_this, sizeof( vout_thread_t ) );
>     if( p_sys->p_vout == NULL )
> -    {
> -        msg_Err( p_vout, "out of memory" );
>         return VLC_ENOMEM;
> -    }
>     vlc_object_attach( p_sys->p_vout, p_this );
>
>     p_sys->p_vout->i_window_width = p_vout->i_window_width;
> diff --git a/modules/visualization/galaktos/plugin.c b/modules/visualization/galaktos/plugin.c
> index 4a108e0..69d958d 100644
> --- a/modules/visualization/galaktos/plugin.c
> +++ b/modules/visualization/galaktos/plugin.c
> @@ -201,7 +201,7 @@ static void* Thread( vlc_object_t *p_this )
>
>     /* Get on OpenGL provider */
>     p_thread->p_opengl =
> -        (vout_thread_t *)vlc_object_create( p_this, VLC_OBJECT_OPENGL );
> +        (vout_thread_t *)vlc_object_create( p_this, sizeof( vout_thread_t ) );
>     if( p_thread->p_opengl == NULL )
>     {
>         vlc_restorecancel (canc);
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



More information about the vlc-devel mailing list