[vlc-devel] [PATCH]GSoC 09 qualification task :Add Truran VOD access module

[Rémi Denis-Courmont]

Le jeudi 2 avril 2009 19:02:07 Jean-Baptiste Kempf, vous avez écrit :
> On Thu, Apr 02, 2009 at 11:23:55PM +0800, zhigang wang wrote :
> > > +vlc_module_begin();
> > > +    set_shortname( N_("VOD" ) );
> > > +    set_description( N_("Truran VOD input") );
> > > +    set_category( CAT_INPUT );
> > > +    set_subcategory( SUBCAT_INPUT_ACCESS );
> > > +
> > > +    add_integer( "vod-caching", DEFAULT_PTS_DELAY / 1000, NULL,
> > > CACHING_TEXT,
> > > +                 CACHING_LONGTEXT, true );
> > > +
> > > +     add_bool( "vod-reconnect", 0, NULL, RECONNECT_TEXT,
> > > +              RECONNECT_LONGTEXT, true );
> > > +
> > > +    set_capability( "access", 0 );
> > > +    add_shortcut( "vod" );
> > > +
> > > +    set_callbacks( Open, Close );
> > > +vlc_module_end();
>
> Just out of nowhere, I dislike naming this module "vod", since this a
> very special vod module, and lusers will be confused...

The option names are too generic indeed (--vod-*). There is not much we can do 
about the shortcut, assuming people do already use the vod://.... syntax, say 
in HTML files.

-- 
Rémi Denis-Courmont
http://www.remlab.net/