[vlc-devel] commit: qt4: fix bookmarks memleaks. ( Rémi Duraffort )

git version control git at videolan.org
Fri Apr 3 12:00:54 CEST 2009


vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Fri Apr  3 11:35:44 2009 +0200| [0e8641f3621ae65192a61aba8305790a15343c21] | committer: Rémi Duraffort 

qt4: fix bookmarks memleaks.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0e8641f3621ae65192a61aba8305790a15343c21
---

 modules/gui/qt4/dialogs/bookmarks.cpp |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/modules/gui/qt4/dialogs/bookmarks.cpp b/modules/gui/qt4/dialogs/bookmarks.cpp
index d12eb54..9fa7615 100644
--- a/modules/gui/qt4/dialogs/bookmarks.cpp
+++ b/modules/gui/qt4/dialogs/bookmarks.cpp
@@ -233,17 +233,12 @@ void BookmarksDialog::edit( QTreeWidgetItem *item, int column )
     }
 
     // Send the modification
-    if( input_Control( p_input, INPUT_CHANGE_BOOKMARK, p_seekpoint, i_edit ) !=
-        VLC_SUCCESS )
-        goto clear;
+    input_Control( p_input, INPUT_CHANGE_BOOKMARK, p_seekpoint, i_edit );
 
-// Clear the bookmark list
 clear:
+    // Clear the bookmark list
     for( int i = 0; i < i_bookmarks; i++)
-    {
-        if( p_seekpoint != pp_bookmarks[i] )
-            vlc_seekpoint_Delete( pp_bookmarks[i] );
-    }
+        vlc_seekpoint_Delete( pp_bookmarks[i] );
     free( pp_bookmarks );
 }
 




More information about the vlc-devel mailing list