[vlc-devel] commit: Try to use video-filter instead of vout-filter for deinterlacing. ( Laurent Aimar )

[xxcv]

Hi,
git version control wrote:
> vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Mon Mar 16 23:38:00 2009 +0100| [a43be925489b3b4b659b12490e9fff629cc37a55] | committer: Laurent Aimar 
>
> Try to use video-filter instead of vout-filter for deinterlacing.
>
> It only works for blend and X mode but there are probably the most used.
> When blend/X are enabled/disabled:
>  - It avoids recreating the vout.
>  - It avoids deinterlacing the (soft) subtitles.
> The other modes are not possible without a lot of vout works, so it is
> postponed for later.
>
> As a side effect, the initial value of the menu now takes into account the
> command line options.
>
> Please, report any regression. This code is made complicated by the
> vout filter/video filter2 switches&tricks.
>
>   
Regression:
Pressing "D" shortcut to cycle through deinterlacing functions Discard - 
Blend ...
Or manually goto Video sub context menu select Discard then Blend (and 
it's not checked)

---
At this point Discard deinterlace is On. Selecting Blend... below
---
[099CE9DC] deinterlace generic debug: using blend deinterlace mode
[1333D59C] main video output debug: [7] 2 0
[1333D59C] main video output debug: [8] 2 0
[099CE9DC] deinterlace generic debug: using blend deinterlace method
[1333D59C] main video output debug: [9] 2 1
[095E754C] deinterlace filter debug: deinterlacing
[1333D59C] main video output debug: [10] 4 0
[1333D59C] main video output debug: [11] 4 0
[095E754C] main filter debug: using video filter2 module "deinterlace"
[1333D59C] main video output debug: [12] 2 0
[1333D59C] main video output debug: [13] 2 0
[095E754C] main filter debug: TIMER module_need() : 0.000 ms - Total 
0.000 ms / 1 intvls (Avg 0.000 ms)
[1333D59C] main video output debug: [14] 2 0
[021720B4] main input debug: saving a free vout
[1333D59C] main video output debug: Filter 'deinterlace' (095E754C) 
appended to chain
---
Added blend deinterlace
---
...
[03C45B04] qt4 window debug: releasing video...
[03BCE02C] qt4 interface debug: Video is not needed anymore
---
vout has been reset
---
...
[1333D59C] main video output debug: Filter 'deinterlace' (095E754C) 
removed from chain
[095E754C] main filter debug: removing module "deinterlace"
[1333D59C] main video output debug: removing module "deinterlace"
---
blend deinterlace automatically removed
---
[099CE9DC] direct3d video output debug: DirectXCreateWindow
[03C45A4C] main window debug: looking for hwnd module: 2 candidates
[03C45A4C] qt4 window debug: requesting video...
[03BCE02C] qt4 interface debug: Video was requested -1, -1
---
new vout.
---
The result becomes you can't switch from Discard to Blend.

Also it will crash when you switch from Discard to blend then
Discard to X or the other way around or
Discard and crash

Call stack:
66743B64  liblibmpeg2_plugin.dll:66743B64  mpeg2_parse  decode.c:58

6A56BAD0  libvlccore.dll:6A56BAD0  DecoderDecodeVideo  decoder.c:1435

6A56B668  libvlccore.dll:6A56B668  DecoderProcess  decoder.c:1809

6A56C158  libvlccore.dll:6A56C158  DecoderThread  decoder.c:887

6A5BB821  libvlccore.dll:6A5BB821  thread_entry  threads.c:1002

6A5BBB1A  libvlccore.dll:6A5BBB1A  vlc_entry  threads.c:688

75352CCE  msvcrt.dll:75352CCE  wcstombs_s
75352DEB  msvcrt.dll:75352DEB  _beginthreadex
754BE3F3  kernel32.dll:754BE3F3  BaseThreadInitThunk
76FBCFED  ntdll.dll:76FBCFED  RtlCreateUserProcess
76FBD1FF  ntdll.dll:76FBD1FF  RtlCreateProcessParameters

>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a43be925489b3b4b659b12490e9fff629cc37a55
>>     
> ---
>
>  src/video_output/video_output.c  |  240 ++++++++++++++++++++++++++++----------
>  src/video_output/vout_internal.h |    1 +
>  2 files changed, 180 insertions(+), 61 deletions(-)
>
> Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=a43be925489b3b4b659b12490e9fff629cc37a55
>   

Regards

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090404/b297ae55/attachment.html>