[vlc-devel] commit: win32: fix %zu fixups - dont use mingw's vsnprintf (David Flynn )

xxcv xxcv07 at gmail.com
Sat Apr 4 11:28:37 CEST 2009


git version control wrote:
> vlc | branch: master | David Flynn <davidf at rd.bbc.co.uk> | Wed Apr  1 21:40:02 2009 +0000| [151982aab503fa812cd4d6e830df34e78871c106] | committer: Jean-Baptiste Kempf 
>
> win32: fix %zu fixups - dont use mingw's vsnprintf
>
> Traditionally, MSVCRT has provided vsnprintf as _vsnprintf;
> to 'aid' portability/standards compliance, mingw provide a
> static version of [v]snprintf that is buggy.
>
> The bug manifests as %lx is treated as a 64bit argument not
> 32bit, ie consumes two 32bit parameters.  if a %s were to
> follow a %lx, bad things can happen.
>
> Solution: Be sure to use the MSVCRT version, at least it
> behaves as expected
>
> Additionally, make it a bit more obvious when vlc wrappers
> are being called by other wrappers.
>
> Signed-off-by: David Flynn <davidf at rd.bbc.co.uk>
> Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
>   
Did anybody else tested these patches before you signed them off and commit?

Because I just found out it crashes when loading wmv / asf files... #2629

Regards



More information about the vlc-devel mailing list