[vlc-devel] commit: win32: fix %zu fixups - dont use mingw's vsnprintf (David Flynn )

[xxcv]

David Flynn wrote:
> On 2009-04-04, xxcv <xxcv07 at gmail.com> wrote:
>   
>> Jean-Baptiste Kempf wrote:
>>     
>>> On Sat, Apr 04, 2009 at 08:28:37PM +1100, xxcv wrote :
>>>   
>>>       
>>>> git version control wrote:
>>>>     
>>>>         
>>>>> vlc | branch: master | David Flynn <davidf at rd.bbc.co.uk> | Wed Apr  1 
>>>>> 21:40:02 2009 +0000| [151982aab503fa812cd4d6e830df34e78871c106] | 
>>>>> committer: Jean-Baptiste Kempf 
>>>>> win32: fix %zu fixups - dont use mingw's vsnprintf
>>>>>
>>>>> Traditionally, MSVCRT has provided vsnprintf as _vsnprintf;
>>>>> to 'aid' portability/standards compliance, mingw provide a
>>>>> static version of [v]snprintf that is buggy.
>>>>>
>>>>>       
>>>>>           
>> Indeed that there's 2 problems with wmv one is with these patch series.
>>     
>
> On the *printf problem, are you either able to identify which module it
> dies in? or grab a stack trace?
>
> The problem is usually down to a a conflict between vlc being written in
> c99 and microsoft who write to god knows what. ie, a format specifier
> that MS don't understand is used.
>
> There is a further patch (yet to be written), that requires
> mingw-runtime > 3.13 and deactivates the using of msvcrt _vsnprintf.
>
> The problem is complicated by wince, which doesn't use the mingw-runtime
> so needs some form of compatability.  One solution is to provide a
> vsnprintf implementation for rubbish platforms, i got most of the way
> there, but lost the will to live at implementing c99 compliant double
> handling.
>
> ..david
>
>   
Ok... this took me few hours to find.

When ffmpeg is compiled using liboil "0.3.16" and schroedinger "1.0.6"
liboil is compiled without patch, schroedinger is compiled with 
schroedinger-1.0.6-fixes.patch
The libavcodec_plugin.dll will crash on loading wmv file on win32 !!!

So that's 2 regression issues with your updates to schroedinger and the 
modified win32 vlc*printf* functions,
during the _/*__features freeze__*/_ If I'm not wrong...













-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090405/c11af056/attachment.html>