[vlc-devel] commit: Do not print the password in the log. That's dangerous! ( Antoine Cellerier )

git version control git at videolan.org
Mon Apr 6 22:24:03 CEST 2009


vlc | branch: 0.9-bugfix | Antoine Cellerier <dionoea at videolan.org> | Mon Apr  6 22:11:07 2009 +0200| [5924456f223c7a08907e1054375d11c55f40f42b] | committer: Antoine Cellerier 

Do not print the password in the log. That's dangerous!

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5924456f223c7a08907e1054375d11c55f40f42b
---

 modules/access/http.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/modules/access/http.c b/modules/access/http.c
index 66e32ff..c465fa4 100644
--- a/modules/access/http.c
+++ b/modules/access/http.c
@@ -452,7 +452,13 @@ connect:
         if( i_ret == DIALOG_OK_YES )
         {
             msg_Dbg( p_access, "retrying with user=%s, pwd=%s",
-                        psz_login, psz_password );
+                     psz_login,
+#if 1
+                     "yeah right, like we're going to print a password."
+#else
+                     psz_password
+#endif
+                        );
             if( psz_login ) p_sys->url.psz_username = strdup( psz_login );
             if( psz_password ) p_sys->url.psz_password = strdup( psz_password );
             free( psz_login );




More information about the vlc-devel mailing list