[vlc-devel] commit: Improve debug ( Rémi Denis-Courmont )

[git version control]

vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Wed Apr  8 23:15:43 2009 +0300| [8a93a226efd142eeb600362387feb61325c8f3c4] | committer: Rémi Denis-Courmont 

Improve debug

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=8a93a226efd142eeb600362387feb61325c8f3c4
---

 modules/video_output/xcb/events.c |    2 +-
 modules/video_output/xcb/window.c |    1 +
 modules/video_output/xcb/xcb.c    |    5 +++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/modules/video_output/xcb/events.c b/modules/video_output/xcb/events.c
index 0f09885..908f811 100644
--- a/modules/video_output/xcb/events.c
+++ b/modules/video_output/xcb/events.c
@@ -110,7 +110,7 @@ int ProcessEvent (vout_thread_t *vout, xcb_generic_event_t *ev)
             break;
 
         default:
-            msg_Dbg (vout, "unhandled event %02x", (unsigned)ev->response_type);
+            msg_Dbg (vout, "unhandled event %"PRIu8, ev->response_type);
     }
 
     free (ev);
diff --git a/modules/video_output/xcb/window.c b/modules/video_output/xcb/window.c
index f31690a..6271316 100644
--- a/modules/video_output/xcb/window.c
+++ b/modules/video_output/xcb/window.c
@@ -183,6 +183,7 @@ static void *Thread (void *data)
         {
             if (ProcessKeyEvent (p_sys->keys, ev) == 0)
                 continue;
+            msg_Dbg (wnd, "unhandled event: %"PRIu8, ev->response_type);
             free (ev);
         }
         vlc_restorecancel (canc);
diff --git a/modules/video_output/xcb/xcb.c b/modules/video_output/xcb/xcb.c
index 8d96b1b..0f1eafe 100644
--- a/modules/video_output/xcb/xcb.c
+++ b/modules/video_output/xcb/xcb.c
@@ -417,12 +417,13 @@ static int Init (vout_thread_t *vout)
                                             &width, &height);
         if (p_sys->embed == NULL)
         {
-            msg_Err (vout, "cannot get window");
+            msg_Err (vout, "cannot get parent window");
             return VLC_EGENERIC;
         }
         p_sys->parent = p_sys->embed->handle.xid;
     }
 
+    /* FIXME: incorrect placement if resize now */
     vout_PlacePicture (vout, width, height, &x, &y, &width, &height);
 
     /* FIXME: I don't get the subtlety between output and fmt_out here */
@@ -446,7 +447,7 @@ static int Init (vout_thread_t *vout)
     /* Create window */
     const uint32_t mask = XCB_CW_BACK_PIXEL | XCB_CW_EVENT_MASK
                         | XCB_CW_COLORMAP;
-    uint32_t values[] = {
+    const uint32_t values[] = {
         /* XCB_CW_BACK_PIXEL */
         screen->black_pixel,
         /* XCB_CW_EVENT_MASK */