[vlc-devel] commit: contribs: don't compile ffmpeg with mdynamic-no-pic on PPC-Macs, as this is a really bad idea. You need PIC in shared libs on this platform . ( Felix Paul Kühne )

[git version control]

vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Mon Apr 13 23:10:31 2009 +0200| [766e15644a970d699530e68399edd5912e7faea5] | committer: Felix Paul Kühne 

contribs: don't compile ffmpeg with mdynamic-no-pic on PPC-Macs, as this is a really bad idea. You need PIC in shared libs on this platform.

This slows down the compilation speed by 5%, but that should be fine. Pointed by nobody.loopback on the forum.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=766e15644a970d699530e68399edd5912e7faea5
---

 extras/contrib/src/Makefile                        |    2 ++
 .../src/Patches/ffmpeg-darwin-ppc-mdynamic.patch   |   12 ++++++++++++
 2 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/extras/contrib/src/Makefile b/extras/contrib/src/Makefile
index 5caf082..4c40838 100644
--- a/extras/contrib/src/Makefile
+++ b/extras/contrib/src/Makefile
@@ -1089,6 +1089,8 @@ ifdef HAVE_BEOS
 endif
 ifdef HAVE_DARWIN_OS_ON_INTEL
 	(cd $@; patch -p0 < ../Patches/ffmpeg-macosx-intel-mmx.patch)
+else
+    (cd $@; patch -p0 < ../Patches/ffmpeg-darwin-ppc-mdynamic.patch) 
 endif
 ifdef HAVE_UCLIBC
 	patch -p0 < Patches/ffmpeg-svn-uclibc.patch
diff --git a/extras/contrib/src/Patches/ffmpeg-darwin-ppc-mdynamic.patch b/extras/contrib/src/Patches/ffmpeg-darwin-ppc-mdynamic.patch
new file mode 100644
index 0000000..25ae82a
--- /dev/null
+++ b/extras/contrib/src/Patches/ffmpeg-darwin-ppc-mdynamic.patch
@@ -0,0 +1,12 @@
+Index: configure
+===================================================================
+--- configure	(revision 18349)
++++ configure	(working copy)
+@@ -1758,7 +1758,6 @@
+         add_cflags -pipe
+         check_cflags -force_cpusubtype_ALL
+         check_cflags -Wno-sign-compare
+-        enabled shared || check_cflags -mdynamic-no-pic
+     fi
+ fi
+