[vlc-devel] commit: contribs: fixed liboil compilation on PPC machines ( Felix Paul Kühne )

[Felix Paul Kühne]

Am 14.04.2009 um 10:14 schrieb David Flynn:

> On 2009-04-13, git version control <git at videolan.org> wrote:
>> vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> |  
>> Mon Apr 13 17:32:59 2009 +0200|  
>> [5cce27fe6b0a01a972aec5a7208731af556c3b3b] | committer: Felix Paul  
>> Kühne
> ...
>> +diff -ru liboil.orig/examples/videoscale/vs_scanline.h liboil/ 
>> examples/videoscale/vs_scanline.h
> ...
>> ++#import <stdint.h>
>
> #import ?
That's an Obj-C habit. #include is fine, too.

> Actually, what exactly is broken here?  I'll get it sent upstream.
This patch shouldn't be send upstream, as it just works-around the  
problem instead of fixing it. liboil's configure script misinterprets  
llvm-gcc-4.2 on PPC Macs, so _STDINT_HAVE_INT_LEAST32_T and  
_STDINT_NEED_INT_FAST_T get redefined although everything is fine.  
This leads to strange compilation failures all of the place (error  
messages à la "a * or ) is required" when parsing function( int16_t  
*i1 ), etc.)
liboil-stdint.h on PPC is huge compared to the 10 lines on Intel-based  
Macs...
I've just attached both header files and each config.log, so you get  
an impression. Ideally, liboil should behave the same on both  
platforms as both the compiler and the SDK are exactly the same.

If you need access to a PPC-based Mac, we can surely arrange that.


Best regards,


Felix


--
VideoLAN
Felix Paul Kühne
Co-Developer of VLC's Mac OS X port
http://www.videolan.org/vlc


-------------- next part --------------
A non-text attachment was scrubbed...
Name: configlog-and-headers.tbz
Type: application/octet-stream
Size: 19539 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090414/0680a8c2/attachment.obj>
-------------- next part --------------