[vlc-devel] [PATCH] Chorus Flanger audio filter

[Rémi Denis-Courmont]

	Hello,

Le mardi 7 avril 2009, Srikanth Raju a écrit :
> I've attached a basic chorus/flanger audio filter. Need some feedback
> for it.

I'm not very knowledgeable on audio filtering. However, you should:
 - remove dead debugging code, especially with swear words,
 - not include header files you really don't need (errno, ctype, signal)
 - not alter the filter object when Open() returns VLC_EGENERIC.
 - not leak p_sys when Open() fails.
 - remove the useless if(p_sys) in Close().

Best regards,

-- 
Rémi Denis-Courmont
http://www.remlab.net/