[vlc-devel] commit: Memory leak ( Rémi Denis-Courmont )

git version control git at videolan.org
Fri Apr 17 22:39:47 CEST 2009


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Fri Apr 17 23:05:16 2009 +0300| [6e31246bd3ea76be79e08643a76203efdb265e4e] | committer: Rémi Denis-Courmont 

Memory leak

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6e31246bd3ea76be79e08643a76203efdb265e4e
---

 modules/video_output/xcb/x11.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/modules/video_output/xcb/x11.c b/modules/video_output/xcb/x11.c
index 80eef54..b598edd 100644
--- a/modules/video_output/xcb/x11.c
+++ b/modules/video_output/xcb/x11.c
@@ -275,16 +275,16 @@ static int Open (vlc_object_t *obj)
     {
         xcb_shm_query_version_cookie_t ck;
         xcb_shm_query_version_reply_t *r;
-        xcb_generic_error_t *err;
 
         ck = xcb_shm_query_version (p_sys->conn);
-        r = xcb_shm_query_version_reply (p_sys->conn, ck, &err);
+        r = xcb_shm_query_version_reply (p_sys->conn, ck, NULL);
         if (!r)
         {
             msg_Err (vout, "shared memory (MIT-SHM) not available");
             msg_Warn (vout, "display will be slow");
             p_sys->shm = false;
         }
+        free (r);
     }
 
     /* Get window */
@@ -468,8 +468,7 @@ static int Init (vout_thread_t *vout)
         ck = xcb_get_geometry (p_sys->conn, p_sys->parent);
 
         xcb_get_geometry_reply_t *geo;
-        xcb_generic_error_t *err;
-        geo = xcb_get_geometry_reply (p_sys->conn, ck, &err);
+        geo = xcb_get_geometry_reply (p_sys->conn, ck, NULL);
         width = geo->width;
         height = geo->height;
         free (geo);




More information about the vlc-devel mailing list