[vlc-devel] commit: macosx: fixed a few bugs found by clang's code analysis ( Felix Paul Kühne )

git version control git at videolan.org
Sat Apr 18 16:36:03 CEST 2009


vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Sat Apr 18 16:35:41 2009 +0200| [4257d965c9d0b60661e52d1ee58a2ffd6ff1c719] | committer: Felix Paul Kühne 

macosx: fixed a few bugs found by clang's code analysis

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4257d965c9d0b60661e52d1ee58a2ffd6ff1c719
---

 modules/gui/macosx/controls.m |    2 +-
 modules/gui/macosx/intf.m     |    2 ++
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/modules/gui/macosx/controls.m b/modules/gui/macosx/controls.m
index 561e09d..084c7f1 100644
--- a/modules/gui/macosx/controls.m
+++ b/modules/gui/macosx/controls.m
@@ -1094,7 +1094,7 @@
     }
 
     /* Special case for telx menu */
-    if( [[o_mi title] isEqualToString: _NS("Normal Size")] );
+    if( [[o_mi title] isEqualToString: _NS("Normal Size")] )
     {
         NSMenuItem *item = [[o_mi menu] itemWithTitle:_NS("Teletext")];
 		bool b_telx = p_input && var_GetInteger( p_input, "teletext-es" ) >= 0;
diff --git a/modules/gui/macosx/intf.m b/modules/gui/macosx/intf.m
index 30eb9d5..d411dc0 100644
--- a/modules/gui/macosx/intf.m
+++ b/modules/gui/macosx/intf.m
@@ -760,7 +760,9 @@ static VLCMain *_o_sharedMainInstance = nil;
     /* remove global observer watching for vout device changes correctly */
     [[NSNotificationCenter defaultCenter] removeObserver: self];
 
+#ifdef UPDATE_CHECK
     [o_update end];
+#endif
 
     /* release some other objects here, because it isn't sure whether dealloc
      * will be called later on */




More information about the vlc-devel mailing list