[vlc-devel] [PATCH] Qt4 playlist: disable dropping onto items which are not containers (nodes)

[Jakob Leben]

2009/8/1 Rémi Denis-Courmont <remi at remlab.net>

> Le vendredi 31 juillet 2009 11:19:14 Jakob Leben, vous avez écrit :
> > Disabling Qt::ItemIsDropEnabled for items which are not containers or
> nodes
> > makes the use of playlist smoother.
> >
> > Condition for this patch is my previously submitted patch "Qt4 Playlist
> > fix: when moving items keep their original order" because previously to
> > that patch, moving operations within qt4 playlist are carried out only if
> > dropping onto items (not between them).
>
> I'm not sure if we want this - won't it make item insertion arbitrarily
> difficult? But most importantly, since I cannot apply it I cannot test it
> either.
>
> error: patch failed:
> modules/gui/qt4/components/playlist/playlist_model.cpp:116
> error: modules/gui/qt4/components/playlist/playlist_model.cpp: patch does
> not
> apply
> Patch failed at 0001 Qt4 playlist: disable dropping onto items which are
> not
> containers (nodes)
>
>
This patch actually makes moving elements easier, because instead of having
three distinct areas for mouse pointer over an item, you have only two.
Before the three areas were like this - from top to bottom: drop at item
index  // drop into item (which was before interpreted as drop at item item
// drop at item index + 1. But with this patch the middle area is not
tracked, so every item is split only into two areas plus dropping on upper
area at index i has the same effect as dropping on bottom area at index i-1.

Attached is again the same patch and it should git-apply. Try out please.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090801/2d03ba79/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Qt4-playlist-disable-dropping-onto-items-which-are.patch
Type: text/x-diff
Size: 1338 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090801/2d03ba79/attachment.patch>