[vlc-devel] [PATCH] -- core(update.c) : correct object release misplaced and memory leaks

Rafaël Carré rafael.carre at gmail.com
Mon Aug 3 14:09:33 CEST 2009

On Mon, 3 Aug 2009 13:25:07 +0200
"brezhoneg1" <brezhoneg1 at yahoo.fr> wrote:

> This patch corrects :
> - a vlc_object_release misplaced
>   The object cannot be released while the associated thread is still
> running (assert failed)

You add a memory leak there.

The problem is that the job of releasing the object is given to the
thread associated to this object (I can't think of another way to
manage the thread which is downloading the updates)

There seems to be no problem with a thread destroying the object it is
associated to (there is no crash if you remove this assertion).
Perhaps the assertion could check if the running thread is the caller
of vlc_object_destroy?

Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090803/52e7ee12/attachment.sig>

More information about the vlc-devel mailing list